Files: 
CommentFileSizeAuthor
#6 views-2002476-elementType.patch2.62 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 55,999 pass(es). View
#4 views-2002476-elementType-4.patch2.96 KBJeroenT
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-2002476-elementType-4.patch. Unable to apply patch. See the log in the details link for more information. View
#2 views-2002476-elementType.patch2.6 KBphenaproxima
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Comments

phenaproxima’s picture

Assigned: Unassigned » phenaproxima
phenaproxima’s picture

Assigned: phenaproxima » Unassigned
Status: Active » Needs review
FileSize
2.6 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git]. View

Patch passed all the field handler tests on my localhost.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -198,7 +198,7 @@ public function label() {
+  function elementType($none_supported = FALSE, $default_empty = FALSE, $inline = FALSE) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/Markup.phpundefined
@@ -54,7 +54,7 @@ function render($values) {
+  function elementType($none_supported = FALSE, $default_empty = FALSE, $inline = FALSE) {

Add public access modifier in front of the functions to adher to the new OOP standards.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
2.96 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch views-2002476-elementType-4.patch. Unable to apply patch. See the log in the details link for more information. View

added public in front of the function.

Status: Needs review » Needs work

The last submitted patch, views-2002476-elementType-4.patch, failed testing.

JeroenT’s picture

FileSize
2.62 KB
PASSED: [[SimpleTest]]: [MySQL] 55,999 pass(es). View

right patch (i hope so)

JeroenT’s picture

Status: Needs work » Needs review

marking as needs review.

oenie’s picture

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

oenie’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 9853507 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.