Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 views-2002476-elementType.patch2.62 KBjeroent
#4 views-2002476-elementType-4.patch2.96 KBjeroent
#2 views-2002476-elementType.patch2.6 KBphenaproxima

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
StatusFileSize
new views-2002476-elementType.patch2.6 KB

Patch passed all the field handler tests on my localhost.

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -198,7 +198,7 @@ public function label() {
+  function elementType($none_supported = FALSE, $default_empty = FALSE, $inline = FALSE) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/Markup.phpundefined
@@ -54,7 +54,7 @@ function render($values) {
+  function elementType($none_supported = FALSE, $default_empty = FALSE, $inline = FALSE) {

Add public access modifier in front of the functions to adher to the new OOP standards.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new views-2002476-elementType-4.patch2.96 KB

added public in front of the function.

Status: Needs review » Needs work

The last submitted patch, views-2002476-elementType-4.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
StatusFileSize
new views-2002476-elementType.patch2.62 KB

right patch (i hope so)

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

marking as needs review.

oenie’s picture

oenie commented

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 9853507 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.