Files: 
CommentFileSizeAuthor
#8 views-rename_function-2002466-7.patch4.22 KBdruderman
PASSED: [[SimpleTest]]: [MySQL] 56,098 pass(es). View
#4 views-rename_function-2002466-3.patch4.22 KBhugo.lallo
PASSED: [[SimpleTest]]: [MySQL] 55,714 pass(es). View
#2 views-rename_function-2002466-2.patch3.51 KBdruderman
FAILED: [[SimpleTest]]: [MySQL] 55,840 pass(es), 1 fail(s), and 0 exception(s). View

Comments

druderman’s picture

Assigned: Unassigned » druderman

At drupalcon sprint.

druderman’s picture

Status: Active » Needs review
FileSize
3.51 KB
FAILED: [[SimpleTest]]: [MySQL] 55,840 pass(es), 1 fail(s), and 0 exception(s). View
oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/field/lib/Drupal/field/Plugin/views/field/Field.phpundefined
@@ -793,7 +793,7 @@ function render_item($count, $item) {
+  function documentSelfTokens(&$tokens) {

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/TaxonomyIndexTid.phpundefined
@@ -134,7 +134,7 @@ function render_item($count, $item) {
+  function documentSelfTokens(&$tokens) {

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/field/Roles.phpundefined
@@ -71,7 +71,7 @@ function render_item($count, $item) {
+  function documentSelfTokens(&$tokens) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -1579,7 +1579,7 @@ function add_self_tokens(&$tokens, $item) { }
+  function documentSelfTokens(&$tokens) { }

Add protected access modifier in front of the function to adher to the new OOP standards.

hugo.lallo’s picture

Status: Needs work » Needs review
FileSize
4.22 KB
PASSED: [[SimpleTest]]: [MySQL] 55,714 pass(es). View
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

druderman’s picture

Assigned: druderman » Unassigned

Makes sense. Thanks.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl http://drupal.org/files/views-rename_function-2003350-4.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1456  100  1456    0     0   4127      0 --:--:-- --:--:-- --:--:--  8416
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php:1208
error: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php: patch does not apply
druderman’s picture

Status: Needs work » Needs review
FileSize
4.22 KB
PASSED: [[SimpleTest]]: [MySQL] 56,098 pass(es). View

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-rename_function-2002466-7.patch, failed testing.

druderman’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 176968c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.