Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#4 drupal-camelcase-replace-2002436.4.patch1 KBbaldwinlouie
#2 drupal-camelcase-replace-2002436-7450518.patch1021 bytesbaldwinlouie

Comments

baldwinlouie’s picture

baldwinlouie commented
Assigned: Unassigned » baldwinlouie

taking by baldwinlouie and sillygwailo

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new drupal-camelcase-replace-2002436-7450518.patch1021 bytes

attaching patch

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -703,7 +703,7 @@ function default_not_found() {
+  function defaultAccessDenied() {

Add public access modifier in front of the functions to adher to the new OOP standards.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review
StatusFileSize
new drupal-camelcase-replace-2002436.4.patch1 KB

rerolling with access modifier

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 0bed623 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.