Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sillygwailo’s picture

Assigned: Unassigned » sillygwailo

Taking this one with baldwinlouie.

sillygwailo’s picture

Status: Active » Needs review
FileSize
1.59 KB

Patch attached.

oenie’s picture

Status: Needs review » Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -1213,7 +1213,7 @@ public function exposedInfo() {
+  function convertExposedInput(&$input, $selected_group_id = NULL) {

Add public access modifier in front of the functions to adher to the new OOP standards.

sillygwailo’s picture

Status: Needs work » Needs review
FileSize
1.6 KB

Re-rolling with public access modifier.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, 2002432-rename-convert_exposed_input.patch, failed testing.

oenie’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 6295bdf and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.