Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#4 views_rename_compile_fields-2002428-4.patch884 bytesnathangervais
#2 views-rename-compile_fields-2002428-2.patch866 byteshansenm

Comments

hansenm’s picture

hansenm commented
Assigned: Unassigned » hansenm

I'll take this one.

hansenm’s picture

hansenm commented
Status: Active » Needs review
StatusFileSize
new views-rename-compile_fields-2002428-2.patch866 bytes

Submitting a patch to update the compile_fields method.

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1189,7 +1189,7 @@ function get_non_aggregates() {
+  function compileFields($query) {

Add protected access modifier in front of the functions to adher to the new OOP standards.

nathangervais’s picture

nathangervais commented
Assigned: hansenm » nathangervais
Status: Needs work » Needs review
StatusFileSize
new views_rename_compile_fields-2002428-4.patch884 bytes

Rerolled Patch with Protected Access modifier

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Rename Views method compile_fields() to compileFields() » Change notice: Rename Views method compile_fields() to compileFields()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Change notice: Rename Views method compile_fields() to compileFields() » Rename Views method compile_fields() to compileFields()
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Assigned: nathangervais » Unassigned
Status: Active » Fixed
Issue tags: -Needs change record

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.

Automatically closed -- issue fixed for 2 weeks with no activity.