Files: 
CommentFileSizeAuthor
#10 2002422-chng-clear_fields.patch1.36 KB_andy
PASSED: [[SimpleTest]]: [MySQL] 57,364 pass(es).
[ View ]
#8 2002950-chng-use_count_query-5.patch1.38 KB_andy
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002950-chng-use_count_query-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#5 Rename_Views_method_clearFields-2002422-5.patch1.64 KBJeroenT
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch Rename_Views_method_clearFields-2002422-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 Rename_Views_method-2002422-2.patch1.36 KBNonProfit
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

NonProfit’s picture

Assigned:Unassigned» NonProfit
NonProfit’s picture

Assigned:NonProfit» Unassigned
Status:Active» Needs review
StatusFileSize
new1.36 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Patch created.

dawehner’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -796,7 +796,7 @@ function add_field($table, $field, $alias = '', $params = array()) {
+  function clearFields() {

Should be marked as public

Status:Needs review» Needs work

The last submitted patch, Rename_Views_method-2002422-2.patch, failed testing.

JeroenT’s picture

StatusFileSize
new1.64 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch Rename_Views_method_clearFields-2002422-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

rename views method clear_fields to clearFields.

JeroenT’s picture

Status:Needs work» Needs review

marking as needs review.

Status:Needs review» Needs work

The last submitted patch, Rename_Views_method_clearFields-2002422-5.patch, failed testing.

_andy’s picture

Assigned:Unassigned» _andy
Status:Needs work» Needs review
StatusFileSize
new1.38 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 2002950-chng-use_count_query-5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

The submitted patch was wrapped in html. I removed the extra html and resubmitted.

Status:Needs review» Needs work

The last submitted patch, 2002950-chng-use_count_query-5.patch, failed testing.

_andy’s picture

StatusFileSize
new1.36 KB
PASSED: [[SimpleTest]]: [MySQL] 57,364 pass(es).
[ View ]

Looks like the original patch in comment 5 also had html replacement characters inside it and so really broke the code. recreated the changes locally and saved a new patch. I think this should do it.

_andy’s picture

Status:Needs work» Needs review
dawehner’s picture

Status:Needs review» Reviewed & tested by the community

There are just two instances

_andy’s picture

Assigned:_andy» Unassigned
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 1f684ba and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.