Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#2 convert-can_group-2002418.patch1.73 KBPsikik

Comments

Psikik’s picture

Psikik commented
Assigned: Unassigned » Psikik
Psikik’s picture

Psikik commented
Assigned: Psikik » Unassigned
Status: Active » Needs review
StatusFileSize
new convert-can_group-2002418.patch1.73 KB

Convert can_group function to camel case, canGroup and add public decorator.

nathangervais’s picture

nathangervais commented
Status: Needs review » Reviewed & tested by the community

Applied the patch all functions named can_group have been renamed as well as the call to it.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, convert-can_group-2002418.patch, failed testing.

Psikik’s picture

Psikik commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: convert-can_group-2002418.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5501be9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.