Files: 
CommentFileSizeAuthor
#2 convert-can_group-2002418.patch1.73 KBPsikik
PASSED: [[SimpleTest]]: [MySQL] 55,747 pass(es).
[ View ]

Comments

Psikik’s picture

Assigned:Unassigned» Psikik
Psikik’s picture

Assigned:Psikik» Unassigned
Status:Active» Needs review
StatusFileSize
new1.73 KB
PASSED: [[SimpleTest]]: [MySQL] 55,747 pass(es).
[ View ]

Convert can_group function to camel case, canGroup and add public decorator.

nathangervais’s picture

Status:Needs review» Reviewed & tested by the community

Applied the patch all functions named can_group have been renamed as well as the call to it.

Status:Reviewed & tested by the community» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, convert-can_group-2002418.patch, failed testing.

Psikik’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#2: convert-can_group-2002418.patch queued for re-testing.

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 5501be9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.