Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 rename-cache-start-2002414-8.patch1.61 KBtheladebug
#5 renamed-cache-start-2002414-4.patch1.61 KBtheladebug
#4 renamed-cache-start-2002414-4.patch1.61 KBtheladebug
#2 renamed-cache-start-2002414.patch1.59 KBtheladebug

Comments

theladebug’s picture

theladebug commented
Assigned: Unassigned » theladebug
theladebug’s picture

theladebug commented
Status: Active » Needs review
StatusFileSize
new renamed-cache-start-2002414.patch1.59 KB
oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -214,7 +214,7 @@ function post_render(&$output) { }
+  function cacheStart() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/None.phpundefined
@@ -23,7 +23,7 @@
+  function cacheStart() { /* do nothing */ }

Add public access modifier in front of the functions to adher to the new OOP standards.

theladebug’s picture

theladebug commented
StatusFileSize
new renamed-cache-start-2002414-4.patch1.61 KB
theladebug’s picture

theladebug commented
StatusFileSize
new renamed-cache-start-2002414-4.patch1.61 KB
theladebug’s picture

theladebug commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, renamed-cache-start-2002414-4.patch, failed testing.

theladebug’s picture

theladebug commented
Status: Needs work » Needs review
StatusFileSize
new rename-cache-start-2002414-8.patch1.61 KB

Looks like I dont read well. Modified protected to public based on feedback.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f13b87c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.