Files: 
CommentFileSizeAuthor
#8 rename-cache-start-2002414-8.patch1.61 KBtheladebug
PASSED: [[SimpleTest]]: [MySQL] 55,875 pass(es).
[ View ]
#5 renamed-cache-start-2002414-4.patch1.61 KBtheladebug
FAILED: [[SimpleTest]]: [MySQL] 55,318 pass(es), 691 fail(s), and 320 exception(s).
[ View ]
#4 renamed-cache-start-2002414-4.patch1.61 KBtheladebug
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch renamed-cache-start-2002414-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
#2 renamed-cache-start-2002414.patch1.59 KBtheladebug
PASSED: [[SimpleTest]]: [MySQL] 55,769 pass(es).
[ View ]

Comments

theladebug’s picture

Assigned:Unassigned» theladebug
theladebug’s picture

Status:Active» Needs review
StatusFileSize
new1.59 KB
PASSED: [[SimpleTest]]: [MySQL] 55,769 pass(es).
[ View ]
oenie’s picture

Status:Needs review» Needs work
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/CachePluginBase.phpundefined
@@ -214,7 +214,7 @@ function post_render(&$output) { }
+  function cacheStart() {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/cache/None.phpundefined
@@ -23,7 +23,7 @@
+  function cacheStart() { /* do nothing */ }

Add public access modifier in front of the functions to adher to the new OOP standards.

theladebug’s picture

StatusFileSize
new1.61 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch renamed-cache-start-2002414-4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
theladebug’s picture

StatusFileSize
new1.61 KB
FAILED: [[SimpleTest]]: [MySQL] 55,318 pass(es), 691 fail(s), and 320 exception(s).
[ View ]
theladebug’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, renamed-cache-start-2002414-4.patch, failed testing.

theladebug’s picture

Status:Needs work» Needs review
StatusFileSize
new1.61 KB
PASSED: [[SimpleTest]]: [MySQL] 55,875 pass(es).
[ View ]

Looks like I dont read well. Modified protected to public based on feedback.

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed f13b87c and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.