Files: 
CommentFileSizeAuthor
#6 views-buildGroupOptions-2002380-6.patch1.44 KBzschmid
PASSED: [[SimpleTest]]: [MySQL] 55,863 pass(es). View
#1 rename_build_group_options-2002380.patch1.01 KBtheladebug
PASSED: [[SimpleTest]]: [MySQL] 55,737 pass(es). View

Comments

theladebug’s picture

Status: Active » Needs review
FileSize
1.01 KB
PASSED: [[SimpleTest]]: [MySQL] 55,737 pass(es). View
Nneka’s picture

Assigned: Unassigned » Nneka
Nneka’s picture

Assigned: Nneka » Unassigned
oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -714,7 +714,7 @@ public function defaultExposeOptions() {
+  function buildGroupOptions() {

Add protected access modifier in front of the function to adher to the new OOP standards.

oenie’s picture

Status: Needs review » Needs work
zschmid’s picture

Status: Needs work » Needs review
FileSize
1.44 KB
PASSED: [[SimpleTest]]: [MySQL] 55,863 pass(es). View

Updated patch

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-buildGroupOptions-2002380-6.patch, failed testing.

zschmid’s picture

Status: Needs work » Needs review
Issue tags: +Novice, +VDC
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c3b21af and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.