Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 views-core-rename-alter-subquery-condition-2002360-06.patch1.65 KBSpartyDan
#2 rename-alter-subquery-condition-2002360-2.patch2.05 KBbrandon_beeler

Comments

brandon_beeler’s picture

brandon_beeler commented
Assigned: Unassigned » brandon_beeler
brandon_beeler’s picture

brandon_beeler commented
Status: Active » Needs review
StatusFileSize
new rename-alter-subquery-condition-2002360-2.patch2.05 KB

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, rename-alter-subquery-condition-2002360-2.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: rename-alter-subquery-condition-2002360-2.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/relationship/GroupwiseMax.phpundefined
@@ -309,7 +309,7 @@ function left_query($options) {
+  function alterSubqueryCondition(AlterableInterface $query, &$conditions) {

Add protected access modifier in front of the function to adhere to the new OOP standards.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-rename-alter-subquery-condition-2002360-06.patch1.65 KB

Added protected access modifier in front of the function to adhere to the new OOP standards.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Thank you

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 93dadb9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.