Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#3 views-alter_display_options_rename-2002358-1.patch1.81 KBjazzdrive3
#4 views-alter_display_options_rename-2002358-4.patch1.81 KBjazzdrive3
#2 views-alter_display_options_rename-2002358-1.patch1.41 KBjazzdrive3
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
Assigned: Unassigned » jazzdrive3
jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
FileSize
views-alter_display_options_rename-2002358-1.patch1.41 KB

Ignore this one.

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
FileSize
views-alter_display_options_rename-2002358-1.patch1.81 KB

Ignore

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
FileSize
views-alter_display_options_rename-2002358-4.patch1.81 KB

Well crap. Ok, here is the properly named patch, with comment number, so there is no confusion. Sorry, new to doing this the proper way.

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Perfect

I searched for all instances of the method and that's all.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-alter_display_options_rename-2002358-4.patch, failed testing.

jazzdrive3’s picture

jazzdrive3 CreditAttribution: jazzdrive3 commented
Status: Needs work » Needs review

#4: views-alter_display_options_rename-2002358-4.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, views-alter_display_options_rename-2002358-4.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#4: views-alter_display_options_rename-2002358-4.patch queued for re-testing.

oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed f6307dd and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.