Files: 
CommentFileSizeAuthor
#9 views-rename_aggregation_method_simple-2002354-9.patch2.49 KBJeroenT
PASSED: [[SimpleTest]]: [MySQL] 57,643 pass(es). View
#6 views-aggregation-method-simple-2002354-6.patch572 bytesSpartyDan
FAILED: [[SimpleTest]]: [MySQL] 57,439 pass(es), 19 fail(s), and 19 exception(s). View
#2 views-2002354-2-aggregation-method-simple.patch565 bytesIshaDakota
FAILED: [[SimpleTest]]: [MySQL] 56,299 pass(es), 19 fail(s), and 19 exception(s). View

Comments

IshaDakota’s picture

Assigned: Unassigned » IshaDakota
IshaDakota’s picture

Assigned: IshaDakota » Unassigned
Status: Active » Needs review
FileSize
565 bytes
FAILED: [[SimpleTest]]: [MySQL] 56,299 pass(es), 19 fail(s), and 19 exception(s). View

Status: Needs review » Needs work

The last submitted patch, views-2002354-2-aggregation-method-simple.patch, failed testing.

Gung Wang’s picture

Assigned: Unassigned » Gung Wang

I take it.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1728,7 +1728,7 @@ function get_aggregation_info() {
+  function aggregationMethodSimple($group_type, $field) {

Add public access modifier in front of the function to adher to the new OOP standards.

SpartyDan’s picture

FileSize
572 bytes
FAILED: [[SimpleTest]]: [MySQL] 57,439 pass(es), 19 fail(s), and 19 exception(s). View

Added public access modifier in front of the function to adher to the new OOP standards.

SpartyDan’s picture

Status: Needs work » Needs review

changed to needs review

Status: Needs review » Needs work

The last submitted patch, views-aggregation-method-simple-2002354-6.patch, failed testing.

JeroenT’s picture

Status: Needs work » Needs review
FileSize
2.49 KB
PASSED: [[SimpleTest]]: [MySQL] 57,643 pass(es). View
oenie’s picture

Looks fine to me now ! Once the patch passed testbot, it's RTBC for me.

oenie’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 2cde13b and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.