Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#9 views-2002350-aggregation-method-distinct-9.diff1.04 KBzschmid
#7 views-2002350-aggregation-method-distinct-6.patch1.11 KBzschmid
#2 views-2002350-2-aggregation-method-distinct.patch712 bytesishadakota

Comments

ishadakota’s picture

ishadakota commented
Assigned: Unassigned » ishadakota
ishadakota’s picture

ishadakota commented
Assigned: ishadakota » Unassigned
Status: Active » Needs review
StatusFileSize
new views-2002350-2-aggregation-method-distinct.patch712 bytes
gung wang’s picture

gung wang commented
Assigned: Unassigned » gung wang

I take it.

oenie’s picture

oenie commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1732,7 +1732,7 @@ function aggregation_method_simple($group_type, $field) {
+  function aggregationMethodDistinct($group_type, $field) {

Add public access modifier in front of the function to adher to the new OOP standards.

oenie’s picture

oenie commented
Status: Needs review » Needs work
zschmid’s picture

zschmid commented
Status: Needs work » Needs review

adding public access modifier

zschmid’s picture

zschmid commented
StatusFileSize
new views-2002350-aggregation-method-distinct-6.patch1.11 KB
oenie’s picture

oenie commented
Status: Needs review » Needs work

Sorry to throw this back again, but it seems we've missed a spot:

core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php, Line 1670:

'method' => 'aggregation_method_distinct'

zschmid’s picture

zschmid commented
StatusFileSize
new views-2002350-aggregation-method-distinct-9.diff1.04 KB

Woops - good catch. sorry about that. here's an updated patch.

zschmid’s picture

zschmid commented
Status: Needs work » Needs review
oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e504933 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.