Files: 
CommentFileSizeAuthor
#9 views-2002350-aggregation-method-distinct-9.diff1.04 KBzschmid
PASSED: [[SimpleTest]]: [MySQL] 57,282 pass(es). View
#7 views-2002350-aggregation-method-distinct-6.patch1.11 KBzschmid
PASSED: [[SimpleTest]]: [MySQL] 57,717 pass(es). View
#2 views-2002350-2-aggregation-method-distinct.patch712 bytesIshaDakota
PASSED: [[SimpleTest]]: [MySQL] 55,867 pass(es). View

Comments

IshaDakota’s picture

Assigned: Unassigned » IshaDakota
IshaDakota’s picture

Assigned: IshaDakota » Unassigned
Status: Active » Needs review
FileSize
712 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,867 pass(es). View
Gung Wang’s picture

Assigned: Unassigned » Gung Wang

I take it.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1732,7 +1732,7 @@ function aggregation_method_simple($group_type, $field) {
+  function aggregationMethodDistinct($group_type, $field) {

Add public access modifier in front of the function to adher to the new OOP standards.

oenie’s picture

Status: Needs review » Needs work
zschmid’s picture

Status: Needs work » Needs review

adding public access modifier

zschmid’s picture

FileSize
1.11 KB
PASSED: [[SimpleTest]]: [MySQL] 57,717 pass(es). View
oenie’s picture

Status: Needs review » Needs work

Sorry to throw this back again, but it seems we've missed a spot:

core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php, Line 1670:

'method' => 'aggregation_method_distinct'

zschmid’s picture

FileSize
1.04 KB
PASSED: [[SimpleTest]]: [MySQL] 57,282 pass(es). View

Woops - good catch. sorry about that. here's an updated patch.

zschmid’s picture

Status: Needs work » Needs review
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed e504933 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.