Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#5 2002338-5-rename-add_tag.patch1.3 KBelvis2
#2 0003-Commit-for-issue-http-drupal.org-node-2002338-to-Ren.patch1.74 KBschiavone

Comments

elvis2’s picture

elvis2 commented
Assigned: Unassigned » elvis2
schiavone’s picture

schiavone commented
StatusFileSize
new 0003-Commit-for-issue-http-drupal.org-node-2002338-to-Ren.patch1.74 KB

created patch

schiavone’s picture

schiavone commented
Assigned: elvis2 » Unassigned
Status: Active » Needs review
sassafrass’s picture

sassafrass commented
Status: Needs review » Reviewed & tested by the community

Applied patch successfully. However, based on other issues in #1856630: [Change notice] [META] Rename Views methods to core standards, I think addTag() method needs to made public to abide by new OOP standards.

elvis2’s picture

elvis2 commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 2002338-5-rename-add_tag.patch1.3 KB

Rerolled with "public" as the access modifier.

elvis2’s picture

elvis2 commented
Assigned: Unassigned » elvis2
oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 6d41161 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.