Comments

elvis2’s picture

Assigned: Unassigned » elvis2
schiavone’s picture

FileSize
1.74 KB
PASSED: [[SimpleTest]]: [MySQL] 57,163 pass(es). View

created patch

schiavone’s picture

Assigned: elvis2 » Unassigned
Status: Active » Needs review
sassafrass’s picture

Status: Needs review » Reviewed & tested by the community

Applied patch successfully. However, based on other issues in #1856630: [Change notice] [META] Rename Views methods to core standards, I think addTag() method needs to made public to abide by new OOP standards.

elvis2’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
1.3 KB
PASSED: [[SimpleTest]]: [MySQL] 55,822 pass(es). View

Rerolled with "public" as the access modifier.

elvis2’s picture

Assigned: Unassigned » elvis2
oenie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 6d41161 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.