Files: 
CommentFileSizeAuthor
#8 2002332-8-rename-add_table.patch9.16 KBelvis2
PASSED: [[SimpleTest]]: [MySQL] 57,340 pass(es).
[ View ]
#3 0001-making-add_table-into-camelcase.patch9.92 KBmikedotexe
PASSED: [[SimpleTest]]: [MySQL] 55,899 pass(es).
[ View ]

Comments

elvis2’s picture

Assigned:Unassigned» elvis2
mikedotexe’s picture

Assigned:elvis2» mikedotexe

I'm going to try to jump on this as it's simple and I'm trying to make my first patch.

mikedotexe’s picture

Status:Active» Needs review
StatusFileSize
new9.92 KB
PASSED: [[SimpleTest]]: [MySQL] 55,899 pass(es).
[ View ]

Here's the patch. I put needs review because it's my first patch, but all the functions called are in indeed coming from views, so it looks like it should solve the issue.

oenie’s picture

+++ b/core/modules/views/lib/Drupal/views/ManyToOneHelper.phpundefined
@@ -65,7 +65,7 @@ public function getField() {
+  function addTable($join = NULL, $alias = NULL) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -364,7 +364,7 @@ function add_relationship($alias, JoinPluginBase $join, $base, $link_point = NUL
+  function addTable($table, $relationship = NULL, JoinPluginBase $join = NULL, $alias = NULL) {

Add public access modifier in front of the functions to adher to the new OOP standards.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 0001-making-add_table-into-camelcase.patch, failed testing.

oenie’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC
oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks good to me now !

elvis2’s picture

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new9.16 KB
PASSED: [[SimpleTest]]: [MySQL] 57,340 pass(es).
[ View ]

Re-rolled patch since access modifier was missing.

Status:Needs review» Needs work
Issue tags:-Novice, -VDC

The last submitted patch, 2002332-8-rename-add_table.patch, failed testing.

elvis2’s picture

Status:Needs work» Needs review
Issue tags:+Novice, +VDC

#8: 2002332-8-rename-add_table.patch queued for re-testing.

oenie’s picture

Status:Needs review» Reviewed & tested by the community

Looks fine now, really :) !

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 2c2ae72 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.