Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 2002276-6-rename-add_self_tokens.patch5.09 KBelvis2
#4 2002276-4-rename-add_self_tokens.patch5.03 KBelvis2
#2 2002276-2-rename-add_self_tokens.patch5.02 KBelvis2

Comments

elvis2’s picture

elvis2 commented
Assigned: Unassigned » elvis2
elvis2’s picture

elvis2 commented
Status: Active » Needs review
StatusFileSize
new 2002276-2-rename-add_self_tokens.patch5.02 KB

Status: Needs review » Needs work

The last submitted patch, 2002276-2-rename-add_self_tokens.patch, failed testing.

elvis2’s picture

elvis2 commented
Status: Needs work » Needs review
StatusFileSize
new 2002276-4-rename-add_self_tokens.patch5.03 KB

Oops, let's try that again.

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/field/lib/Drupal/field/Plugin/views/field/Field.phpundefined
@@ -800,7 +800,7 @@ function document_self_tokens(&$tokens) {
+  function addSelfTokens(&$tokens, $item) {

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Plugin/views/field/TaxonomyIndexTid.phpundefined
@@ -141,7 +141,7 @@ function document_self_tokens(&$tokens) {
+  function addSelfTokens(&$tokens, $item) {

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/field/Permissions.phpundefined
@@ -80,7 +80,7 @@ function document_self_tokens(&$tokens) {
+  function addSelfTokens(&$tokens, $item) {

+++ b/core/modules/user/lib/Drupal/user/Plugin/views/field/Roles.phpundefined
@@ -76,7 +76,7 @@ function document_self_tokens(&$tokens) {
+  function addSelfTokens(&$tokens, $item) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -1572,12 +1572,12 @@ function get_token_values_recursive(array $array, array $parent_keys = array())
+  function addSelfTokens(&$tokens, $item) { }

+++ b/core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/field/FieldTest.phpundefined
@@ -43,9 +43,9 @@ public function getTestValue() {
+  function addSelfTokens(&$tokens, $item) {

Add protected access modifier in front of the method to adher to the new OOP standards.
I assume protected because the calls to this method are in the form of $this->addSelfTokens.

elvis2’s picture

elvis2 commented
Status: Needs work » Needs review
StatusFileSize
new 2002276-6-rename-add_self_tokens.patch5.09 KB

Added the access modifier.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 20d028f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.