There are several places that use double semicolons (see git grep ';;'), which are unneeded.

Let's remove them.

Files: 
CommentFileSizeAuthor
#18 remove_double_semicolons-2002110-18.patch2.2 KBLinL
PASSED: [[SimpleTest]]: [MySQL] 57,706 pass(es).
[ View ]
#15 2002110.patch2.75 KBRobLoach
PASSED: [[SimpleTest]]: [MySQL] 55,852 pass(es).
[ View ]
#12 interdiff_5_10.txt1.47 KBchx
#12 interdiff_8_10.txt798 byteschx
#10 drupal-2002110-9.patch2.75 KBxjm
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#8 2002110-remove-double-semicolons.patch4.09 KBalanmoo
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
#5 drupal-remove-double-semicolons-2002110-comment-1.patch4.82 KBmicahredding
PASSED: [[SimpleTest]]: [MySQL] 56,574 pass(es).
[ View ]
#4 2002110-remove-double-semicolons.patch5.27 KBalanmoo
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

Comments

xjm’s picture

Issue tags:+Novice
alanmoo’s picture

Assigned:Unassigned» alanmoo
micahredding’s picture

Assigned:alanmoo» micahredding

Working on as part of DrupalCon Portland core sprint.

alanmoo’s picture

Assigned:micahredding» Unassigned
Status:Active» Needs review
StatusFileSize
new5.27 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

Searched for double semicolons and removed from .php and .module files (left .js files alone as they were libraries like Modernizr.)

micahredding’s picture

Assigned:Unassigned» micahredding
StatusFileSize
new4.82 KB
PASSED: [[SimpleTest]]: [MySQL] 56,574 pass(es).
[ View ]

Patch created as part of DrupalCon Portland core mentoring sprint.

chx’s picture

Status:Needs review» Needs work

Thanks for contributing to Drupal!

However, you should not change core/lib/Drupal/Component/Archiver/ArchiveTar.php or anything in core/vendor. These are not Drupal files and we do not change them.

alanmoo’s picture

Assigned:micahredding» alanmoo
alanmoo’s picture

StatusFileSize
new4.09 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Removed changes from vendor files

edit...oops, wrong file changed

alanmoo’s picture

What about PluginManagerBase.php? That's also in core/lib/Drupal/Component.

xjm’s picture

StatusFileSize
new2.75 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]
xjm’s picture

Status:Needs work» Needs review
chx’s picture

Status:Needs review» Reviewed & tested by the community
StatusFileSize
new798 bytes
new1.47 KB

Yes, this is correct. Here are the missing interdiffs.

xjm’s picture

Assigned:alanmoo» Unassigned

Status:Reviewed & tested by the community» Needs work

The last submitted patch, drupal-2002110-9.patch, failed testing.

RobLoach’s picture

Status:Needs work» Needs review
StatusFileSize
new2.75 KB
PASSED: [[SimpleTest]]: [MySQL] 55,852 pass(es).
[ View ]

Not sure why it's not passing. Manually went through and re-generated the patch.

Status:Needs review» Needs work
Issue tags:-Novice

The last submitted patch, 2002110.patch, failed testing.

edb’s picture

Status:Needs work» Needs review
Issue tags:+Novice

#15: 2002110.patch queued for re-testing.

LinL’s picture

StatusFileSize
new2.2 KB
PASSED: [[SimpleTest]]: [MySQL] 57,706 pass(es).
[ View ]

Re-roll as PluginManagerBase.php has already been fixed in #2002232: Cleanup PluginManagerBase

RobLoach’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed ecd19d9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.