There are several places that use double semicolons (see git grep ';;'), which are unneeded.

Let's remove them.

CommentFileSizeAuthor
#18 remove_double_semicolons-2002110-18.patch2.2 KBlinl
#15 2002110.patch2.75 KBrobloach
#12 interdiff_5_10.txt1.47 KBchx
#12 interdiff_8_10.txt798 byteschx
#10 drupal-2002110-9.patch2.75 KBxjm
#8 2002110-remove-double-semicolons.patch4.09 KBalanmoo
#5 drupal-remove-double-semicolons-2002110-comment-1.patch4.82 KBmicahredding
#4 2002110-remove-double-semicolons.patch5.27 KBalanmoo

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Novice
alanmoo’s picture

alanmoo commented
Assigned: Unassigned » alanmoo
micahredding’s picture

micahredding commented
Assigned: alanmoo » micahredding

Working on as part of DrupalCon Portland core sprint.

alanmoo’s picture

alanmoo commented
Assigned: micahredding » Unassigned
Status: Active » Needs review
StatusFileSize
new 2002110-remove-double-semicolons.patch5.27 KB

Searched for double semicolons and removed from .php and .module files (left .js files alone as they were libraries like Modernizr.)

micahredding’s picture

micahredding commented
Assigned: Unassigned » micahredding
StatusFileSize
new drupal-remove-double-semicolons-2002110-comment-1.patch4.82 KB

Patch created as part of DrupalCon Portland core mentoring sprint.

chx’s picture

chx commented
Status: Needs review » Needs work

Thanks for contributing to Drupal!

However, you should not change core/lib/Drupal/Component/Archiver/ArchiveTar.php or anything in core/vendor. These are not Drupal files and we do not change them.

alanmoo’s picture

alanmoo commented
Assigned: micahredding » alanmoo
alanmoo’s picture

alanmoo commented
StatusFileSize
new 2002110-remove-double-semicolons.patch4.09 KB

Removed changes from vendor files

edit...oops, wrong file changed

alanmoo’s picture

alanmoo commented

What about PluginManagerBase.php? That's also in core/lib/Drupal/Component.

xjm’s picture

xjm
she/her
Primary language English
commented
StatusFileSize
new drupal-2002110-9.patch2.75 KB
xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs work » Needs review
chx’s picture

chx commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new interdiff_8_10.txt798 bytes
new interdiff_5_10.txt1.47 KB

Yes, this is correct. Here are the missing interdiffs.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: alanmoo » Unassigned

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal-2002110-9.patch, failed testing.

robloach’s picture

robloach
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 2002110.patch2.75 KB

Not sure why it's not passing. Manually went through and re-generated the patch.

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, 2002110.patch, failed testing.

edb’s picture

edb commented
Status: Needs work » Needs review
Issue tags: +Novice

#15: 2002110.patch queued for re-testing.

linl’s picture

linl commented
StatusFileSize
new remove_double_semicolons-2002110-18.patch2.2 KB

Re-roll as PluginManagerBase.php has already been fixed in #2002232: Cleanup PluginManagerBase

robloach’s picture

robloach
he/him
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ecd19d9 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.