Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#7 views-core-add_additional_fields-2001318-7.patch6.28 KBSpartyDan
#5 2001318-05-views-add_additional_fields-rename.patch1.04 KBSpartyDan
views-add_additional_fields-rename.patch1.03 KBchertzog

Comments

Status: Needs review » Needs work

The last submitted patch, views-add_additional_fields-rename.patch, failed testing.

alejandrard’s picture

alejandrard commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

views-add_additional_fields-rename.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -115,7 +115,7 @@ public function query() {
+  function addAdditionalFields($fields = NULL) {

Add protected access modifier in front of the method to adher to the new OOP standards.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review

views-add_additional_fields-rename.patch queued for re-testing.

SpartyDan’s picture

SpartyDan commented
StatusFileSize
new 2001318-05-views-add_additional_fields-rename.patch1.04 KB

added protected keyword

Status: Needs review » Needs work

The last submitted patch, 2001318-05-views-add_additional_fields-rename.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-add_additional_fields-2001318-7.patch6.28 KB

Found additional instances of add_additional_fields that needed to be fixed.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-core-add_additional_fields-2001318-7.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#7: views-core-add_additional_fields-2001318-7.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Rename Views method add_additional_fields() to addAdditionalFields() » [Change notice] Rename Views method add_additional_fields() to addAdditionalFields()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Fixed » Active
Issue tags: +Needs change record

Oops. Needs a change notice.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: [Change notice] Rename Views method add_additional_fields() to addAdditionalFields() » Rename Views method add_additional_fields() to addAdditionalFields()
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Assigned: chertzog » Unassigned
Status: Active » Fixed
Issue tags: -Needs change record

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.

Automatically closed -- issue fixed for 2 weeks with no activity.