Task to convert core/modules/views/lib/Drupal/views/Tests/PluginTypeListTest.php to phpunit.
See #1938068: Convert UnitTestBase to PHPUnit.

CommentFileSizeAuthor
#1 views-plugintype-phpunit-2001218-01.patch854 bytesjhedstrom

Comments

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Active » Needs review
Issue tags: +PHPUnit
StatusFileSize
new views-plugintype-phpunit-2001218-01.patch854 bytes

This one is pretty simple.

ParisLiakos’s picture

ParisLiakos commented
Status: Reviewed & tested by the community » Needs review

dead simple indeed:)

edit: that was completely misguided, so i deleted to avoid confusion

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Component: base system » views.module

There seems to be a lot of different ways already where unit tests are placed. For instance, the breakpoint module (which I followed as an example)

core/modules/breakpoint/tests/Drupal/breakpoint/Tests/BreakpointMediaQueryTest.php

and an existing views test:

core/modules/views/tests/Drupal/Tests/views/UI/ViewsUITest.php

Don't we need Tests in the namespace, and if so, then don't we need that directory one way or another?

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community

ah, i am sorry you are right..thanks:)

Don't we need Tests in the namespace, and if so, then don't we need that directory one way or another?

Lets follow breakpoint example for now (although Core and Component does the reverse)

here is views ui test fixed:
#1998436: Wrong namespace for ViewsUITest

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Fixed

Sweet!

Committed 3af1e98 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
Parent issue: » #1938068: Convert UnitTestBase to PHPUnit