Documents are promoted by default [#2000702]

Comment	File	Size	Author
#5	commons-2000702-5-document-promotion.patch	972 bytes	BarisW
#1	commons-2000702-1-document-promotion.patch	420 bytes	BarisW

File	Size
commons-2000702-1-document-promotion.patch	420 bytes

Comment #2

ezra-g CreditAttribution: ezra-g commented 22 May 2013 at 17:12

Status:

Needs review

» Needs work

Thanks for the patch! Can you provide an upgrade path that updates this value for upgrading sites?

Log in or register to post comments

Comment #3

BarisW CreditAttribution: BarisW commented 22 May 2013 at 20:07

Hi Ezra,

sure, but do we want that? What if people want their Documents on the frontpage? A feature revert sets the default state back to non-promoted, but leaves current nodes untouched. Do you want me to write a script that updates existing document nodes?

Log in or register to post comments

Comment #4

ezra-g CreditAttribution: ezra-g commented 22 May 2013 at 20:20

The general practice in Commons is to revert all exportable components to their defaults if we make changes to those exportables in the Commons codebase.

The assumption is that any site-specific changes to those defaults are exported in code, meaning a features-revert won't wipe out the site-specific settings.

Log in or register to post comments

Comment #5

BarisW CreditAttribution: BarisW commented 22 May 2013 at 20:26

Status:

Needs work

» Needs review

File	Size
commons-2000702-5-document-promotion.patch	972 bytes

Valid assumption (on my side). Patch attached.

Log in or register to post comments

Comment #6

Devin Carlson CreditAttribution: Devin Carlson commented 22 May 2013 at 20:55

Status:

Needs review

» Reviewed & tested by the community

The patch in #5 applied cleanly and stopped Document nodes from being promoted to the front page by default.

Tested by installing commons, checking the publishing options for Documents, applying the patch and running the included update function and finally rechecking the publishing options for Documents.