Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ACF’s picture

Status: Active » Needs review
FileSize
7.73 KB

Patch attached.

ACF’s picture

Oops left in some unnecessary code.

juampynr’s picture

Tagging.

juampynr’s picture

Status: Needs review » Reviewed & tested by the community

Patch applies cleanly.

File uploading tests pass successfully after applying.

I have also had a look at the code of the patch and looks OK to me.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/file/tests/file_test/file_test.moduleundefined
@@ -19,9 +19,7 @@
 function file_test_menu() {
   $items['file-test/upload'] = array(
     'title' => 'Upload test',
-    'page callback' => 'drupal_get_form',
-    'page arguments' => array('_file_test_form'),
-    'access arguments' => array('access content'),
+    'route_name' => 'file_test',
     'type' => MENU_CALLBACK,
   );
   return $items;

Since this is a MENU_CALLBACK I think we can get rid of the entire file_test_menu function.

juampynr’s picture

Status: Needs work » Needs review
FileSize
657 bytes
7.7 KB

Removed file_test_menu().

File upload tests still pass.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

That's fine now.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed eb354a5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.