Subissue of #1971384: [META] Convert page callbacks to controllers.

CommentFileSizeAuthor
#6 2000006-filetestform-file-drupal-6.patch7.7 KBjuampynr
#6 interdiff.txt657 bytesjuampynr
#2 2000006-filetestform-file-drupal-2.patch7.54 KBACF
#1 2000006-filetestform-file-1.patch7.73 KBACF

Comments

ACF’s picture

ACF commented
Status: Active » Needs review
StatusFileSize
new 2000006-filetestform-file-1.patch7.73 KB

Patch attached.

ACF’s picture

ACF commented
StatusFileSize
new 2000006-filetestform-file-drupal-2.patch7.54 KB

Oops left in some unnecessary code.

juampynr’s picture

juampynr commented
Issue tags: +FormInterface, +WSCCI-conversion

Tagging.

juampynr’s picture

juampynr commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly.

File uploading tests pass successfully after applying.

I have also had a look at the code of the patch and looks OK to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/file/tests/file_test/file_test.moduleundefined
@@ -19,9 +19,7 @@
 function file_test_menu() {
   $items['file-test/upload'] = array(
     'title' => 'Upload test',
-    'page callback' => 'drupal_get_form',
-    'page arguments' => array('_file_test_form'),
-    'access arguments' => array('access content'),
+    'route_name' => 'file_test',
     'type' => MENU_CALLBACK,
   );
   return $items;

Since this is a MENU_CALLBACK I think we can get rid of the entire file_test_menu function.

juampynr’s picture

juampynr commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt657 bytes
new 2000006-filetestform-file-drupal-6.patch7.7 KB

Removed file_test_menu().

File upload tests still pass.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

That's fine now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed eb354a5 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.