Use Symfony Request for path module [#1999424]

Comment	File	Size	Author
#4	remove_request_in_path-1999424-3.patch	758 bytes	jlandfried
#2	remove_request_in_path-1999424-2.patch	755 bytes	pbuyle
#1	remove-request.patch	755 bytes	marcingy

Comment #1

marcingy commented 21 May 2013 at 23:04

Status:

Active

» Needs review

Status	File	Size
new	remove-request.patch	755 bytes

Hopefully this kills off $_ in this module.

Log in or register to post comments

Comment #2

pbuyle commented 24 May 2013 at 17:52

Status	File	Size
new	remove_request_in_path-1999424-2.patch	755 bytes

+++ b/core/modules/path/path.admin.inc
@@ -202,9 +202,9 @@ function path_admin_form($form, &$form_state, $path = array('source' => '', 'ali
+  if (Drupal::request()->query->get('destination')) {
     $destination = drupal_get_destination();

This should uses Drupal::request()->query->has('destination') as done in the attached patch.

Log in or register to post comments

Comment #3

kim.pepper

English

🏄‍♂️🇦🇺Sydney, Australia

commented 1 June 2013 at 21:31

Status:

Needs review

» Needs work

+++ b/core/modules/path/path.admin.incundefined
@@ -202,9 +202,9 @@ function path_admin_form($form, &$form_state, $path = array('source' => '', 'ali
+  if (Drupal::request()->query->has('destination')) {
...
+    Drupal::request()->query->remove('destination');

Let's extract a $query variable to reduce verbosity.