Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

  • core/modules/overlay/overlay.module
CommentFileSizeAuthor
#13 1999408-overlay-request.patch697 byteskim.pepper
#13 interdiff.txt694 byteskim.pepper
#11 drupal-use_symfony_request_fro_overlay_module-1999408-11.patch649 bytesAnonymous (not verified)
#6 drupal-use_symfony_request_fro_overlay_module-1999408-4.patch792 bytesAnonymous (not verified)
#2 drupal-use_symfony_request_fro_overlay_module-1999408-2.patch1.64 KBatchijov

Comments

atchijov’s picture

atchijov commented

atchijov & johnbickar working on this.

atchijov’s picture

atchijov commented
StatusFileSize
new drupal-use_symfony_request_fro_overlay_module-1999408-2.patch1.64 KB
atchijov’s picture

atchijov commented
Status: Active » Needs review
atchijov’s picture

atchijov commented
Assigned: Unassigned » atchijov
kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs review » Needs work 
+++ b/core/modules/overlay/overlay.moduleundefined
@@ -151,7 +151,8 @@ function overlay_init() {
+    $query_render = \Drupal::request()->query->get('render');

Maybe rename this to $render?

+++ b/core/modules/overlay/overlay.moduleundefined
@@ -168,7 +169,7 @@ function overlay_init() {
+      \Drupal::request()->query->remove('render');

Let's extract a $query variable to be re-used.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new drupal-use_symfony_request_fro_overlay_module-1999408-4.patch792 bytes

Reroll the patch as the hook_init removed https://drupal.org/node/2013014.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

I have no idea what black magic overlay is trying to do here, but at least this way it's doing it with the right API. :-)

Thanks!

dries’s picture

dries commented

Seems like this needs a re-roll.

dries’s picture

dries commented

#6: drupal-use_symfony_request_fro_overlay_module-1999408-4.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal-use_symfony_request_fro_overlay_module-1999408-4.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new drupal-use_symfony_request_fro_overlay_module-1999408-11.patch649 bytes

Actually this code already committed.

$token = drupal_container()->get('request')->query->get('token');
if (!empty($_POST) || isset($token)) {

Now I Reroll the patch #6.So please Needs Review.

Crell’s picture

Crell commented 
+++ b/core/modules/overlay/overlay.module
@@ -586,7 +586,8 @@
+  $post = Drupal::request()->query->count();

request()->query is the GET parameters. You want the POST parameters, which I believe are request()->request->count().

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
StatusFileSize
new interdiff.txt694 bytes
new 1999408-overlay-request.patch697 bytes

Fixes #12

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

That looks better. Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 9d61e24 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.