Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

  • core/modules/image/image.admin.inc
  • core/modules/image/image.module
Files: 
CommentFileSizeAuthor
#7 convert-image-to-symfony-request-1999384-7.patch1.58 KBAnonymous (not verified)
PASSED: [[SimpleTest]]: [MySQL] 57,584 pass(es).
[ View ]
#7 interdiff-1-6.txt1.64 KBAnonymous (not verified)
#1 1999384-convert-image-to-symfony-request-1.patch1.64 KBbojanz
FAILED: [[SimpleTest]]: [MySQL] 55,876 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Comments

bojanz’s picture

Status:Active» Needs review
StatusFileSize
new1.64 KB
FAILED: [[SimpleTest]]: [MySQL] 55,876 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Wow, this module has ugly logic. I mean, nested ternary operators?!

Status:Needs review» Needs work

The last submitted patch, 1999384-convert-image-to-symfony-request-1.patch, failed testing.

arknoll’s picture

Assigned:Unassigned» arknoll

looking into why this patch failed.

arknoll’s picture

Status:Needs work» Needs review

Status:Needs review» Needs work

The last submitted patch, 1999384-convert-image-to-symfony-request-1.patch, failed testing.

kim.pepper’s picture

Are you still working on this arknoll?

nick_daffodil’s picture

StatusFileSize
new1.64 KB
new1.58 KB
PASSED: [[SimpleTest]]: [MySQL] 57,584 pass(es).
[ View ]

Reroll the #1 patch Needs Review

nick_daffodil’s picture

Status:Needs work» Needs review

Change status to Needs Review

Crell’s picture

Status:Needs review» Reviewed & tested by the community

Thanks, naveenvalecha!

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.