Part of #1998638: Replace almost all remaining superglobals ($_GET, $_POST, etc.) with Symfony Request object

Files that need converting are:

  • core/modules/file/file.install
  • core/modules/file/file.module
CommentFileSizeAuthor
#7 1999370-file-request-5.patch1.72 KBkim.pepper
#7 interdiff.txt2.23 KBkim.pepper
#3 1999370_3-replace_raw-variables-file.patch2.79 KBchertzog
#1 1999370_1-replace_raw-variables-file.patch2.79 KBchertzog

Comments

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Assigned: Unassigned » chertzog
Status: Active » Needs review
StatusFileSize
new 1999370_1-replace_raw-variables-file.patch2.79 KB

Status: Needs review » Needs work

The last submitted patch, 1999370_1-replace_raw-variables-file.patch, failed testing.

chertzog’s picture

chertzog
he/him
Primary language English
Location Harrisburg, PA, USA
commented
Status: Needs work » Needs review
StatusFileSize
new 1999370_3-replace_raw-variables-file.patch2.79 KB

missed a semicolon.

rbayliss’s picture

rbayliss commented 
+++ b/core/modules/file/file.moduleundefined
@@ -738,8 +738,8 @@ function file_cron() {
-  if (empty($_POST['form_build_id']) || $form_build_id != $_POST['form_build_id']) {
+  $request = Drupal::request()->request->get('form_build_id');
+  if (empty($request) || $form_build_id != $request) {

$request is kind of confusing. How about $request_form_build_id?

Status: Needs review » Needs work

The last submitted patch, 1999370_3-replace_raw-variables-file.patch, failed testing.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

Are you still working on this chertzog?

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt2.23 KB
new 1999370-file-request-5.patch1.72 KB

Had a go at making the changes above. Interdiff is messy because i started from scratch again.

Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.