Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Files that need converting are:
core/modules/edit/lib/Drupal/edit/EditController.php
Comments
Comment #1
aaronott CreditAttribution: aaronott commentedComment #2
aaronott CreditAttribution: aaronott commentedComment #4
arknoll CreditAttribution: arknoll commented#1: 1999344_1-replace-raw-variables-edit.patch queued for re-testing.
Comment #6
aaronott CreditAttribution: aaronott commentedThis time with PSR-0 Format
Comment #7
aaronott CreditAttribution: aaronott commentedComment #8
kim.pepperAs this is a method being called in a controller route, we can just pass in Request as a magic parameter, instead of using \Drupal::request()
Comment #9
aaronott CreditAttribution: aaronott commented@kim.pepper
I'm not sure how to do this or what you mean by passing in Request as a magic parameter. Do you have an example or link that I can read up on?
Comment #10
kim.pepperHave a look at \Drupal\aggregator\Routing\AggregatorController::feedRefresh() http://drupalcode.org/project/drupal.git/blob/HEAD:/core/modules/aggrega...
The Request parameter can be passed into the method (in any order) and you don't need to specify it in your route configuration.
Comment #11
aaronott CreditAttribution: aaronott commentedOkay so I think I've got this.
Now allowing for the Request parameter to be passed in.
Comment #12
kim.pepperLooking good!
One minor nitpick:
Should have a new line after last param comment
Comment #13
kim.pepperdouble post
Comment #14
aaronott CreditAttribution: aaronott commentedI thought so but missed it. here it is again. Thanks!
Comment #15
dawehnerLooks great!
Comment #16
alexpottCommitted e0db7eb and pushed to 8.x. Thanks!