Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Files that need converting are:
- core/modules/aggregator/tests/aggregator_test.module
Comment | File | Size | Author |
---|---|---|---|
#3 | 1999338-3-aggregator_test-SERVER-variable-replacement.patch | 1006 bytes | chertzog |
#1 | 1999338-1-aggregator_test-SERVER-variable-replacement.patch | 1.13 KB | chertzog |
Comments
Comment #1
chertzogFirst shot.
Comment #3
chertzogstupid syntax.
Comment #4
chertzogComment #5
pbuyle CreditAttribution: pbuyle commentedNot using
Drupal::request()->server->has('...')
as replacement of the originalisset($_SERVER['...'])
is ok here. Without the consumed server value, the returned value ofstrtotime()
andstripslashes
will beNULL
and""
. Since$if_modified_since
and$if_none_match
are compared to expected values using==
, the behavior should be the same.Comment #6
catchCommitted/pushed to 8.x, thanks!