Files: 
CommentFileSizeAuthor
#12 1998992-12.patch2.06 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 55,840 pass(es).
[ View ]
#12 interdiff-1998992-12.txt1.16 KBdamiankloip
#4 1998992-4-test-only.patch1.2 KBdamiankloip
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]
#4 1998992-4.patch2.08 KBdamiankloip
PASSED: [[SimpleTest]]: [MySQL] 56,906 pass(es).
[ View ]
#1 1998992-typo-1.patch907 bytesandypost
PASSED: [[SimpleTest]]: [MySQL] 55,806 pass(es).
[ View ]

Comments

andypost’s picture

Status:Active» Needs review
StatusFileSize
new907 bytes
PASSED: [[SimpleTest]]: [MySQL] 55,806 pass(es).
[ View ]

probably needs test

amateescu’s picture

Status:Needs review» Reviewed & tested by the community

I wouldn't bother with a test for this :/

swentel’s picture

damiankloip is working on a test actually.

damiankloip’s picture

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new2.08 KB
PASSED: [[SimpleTest]]: [MySQL] 56,906 pass(es).
[ View ]
new1.2 KB
FAILED: [[SimpleTest]]: [MySQL] Drupal installation failed.
[ View ]

I think we should have a test :) and it only takes 5 mins. Here is the test and combined.

swentel’s picture

Status:Needs review» Reviewed & tested by the community

Status:Reviewed & tested by the community» Needs work

The last submitted patch, 1998992-4.patch, failed testing.

swentel’s picture

Status:Needs work» Needs review

Hrm, actually, shouldn't we go to the field admin overview ?
Also you can chain entity_get_form_display()->remove->save().

damiankloip’s picture

#4: 1998992-4.patch queued for re-testing.

swentel’s picture

Nevermind, it's ok, seriously.

swentel’s picture

Status:Needs review» Reviewed & tested by the community
Berdir’s picture

#569434: Remove taxonomy term description field; provide description field for forum taxonomy is triggering this, so it adds additional test coverage for this and is blocked on it right now :)

damiankloip’s picture

Status:Reviewed & tested by the community» Needs review
StatusFileSize
new1.16 KB
new2.06 KB
PASSED: [[SimpleTest]]: [MySQL] 55,840 pass(es).
[ View ]

We don't need to assign entity_get_form_display to a variable.

swentel’s picture

Status:Needs review» Reviewed & tested by the community

Better, thanks!

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Committed 2de1370 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.