The glossary view currently doesn't show anything, which is obviously not the expected behavior.

broken-glossary.png

Files: 
CommentFileSizeAuthor
#16 drupal-1998182-16.patch2.36 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 57,459 pass(es).
[ View ]
#13 drupal-1998182-13.patch3.22 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 55,681 pass(es).
[ View ]
#13 interdiff.txt937 bytesdawehner
#9 drupal-1998182-9.patch3.35 KBdawehner
PASSED: [[SimpleTest]]: [MySQL] 55,790 pass(es).
[ View ]
#9 interdiff.txt879 bytesdawehner
#5 drupal-1998182-5.patch2.5 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 55,857 pass(es), 5 fail(s), and 0 exception(s).
[ View ]
#5 interdiff.txt937 bytesdawehner
#1 drupal-1998182-1-tests.patch1.91 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 57,206 pass(es), 12 fail(s), and 6 exception(s).
[ View ]
#1 drupal-1998182-1.patch2.36 KBdawehner
FAILED: [[SimpleTest]]: [MySQL] 55,674 pass(es), 5 fail(s), and 0 exception(s).
[ View ]
broken-glossary.png5.95 KBdawehner

Comments

dawehner’s picture

Status:Active» Needs review
StatusFileSize
new2.36 KB
FAILED: [[SimpleTest]]: [MySQL] 55,674 pass(es), 5 fail(s), and 0 exception(s).
[ View ]
new1.91 KB
FAILED: [[SimpleTest]]: [MySQL] 57,206 pass(es), 12 fail(s), and 6 exception(s).
[ View ]

Added a test + a fix.

Status:Needs review» Needs work
Issue tags:-VDC

The last submitted patch, drupal-1998182-1.patch, failed testing.

dawehner’s picture

Status:Needs work» Needs review

#1: drupal-1998182-1.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+VDC

The last submitted patch, drupal-1998182-1.patch, failed testing.

dawehner’s picture

Status:Needs work» Needs review
StatusFileSize
new937 bytes
new2.5 KB
FAILED: [[SimpleTest]]: [MySQL] 55,857 pass(es), 5 fail(s), and 0 exception(s).
[ View ]

Let's debug it.

olli’s picture

Looks like #1843764: Convert views/templates/views-view-summary-unformatted.tpl.php to twig would also fix it. There is:

+++ /dev/null
@@ -1,20 +0,0 @@
-    <?php if (!empty($row->separator)): ?><? print $row->separator; ?><?php endif; ?>

Status:Needs review» Needs work

The last submitted patch, drupal-1998182-5.patch, failed testing.

olli’s picture

Do you think we should wait that other issue get in first? Rest of your #1 looks pretty solid.

dawehner’s picture

Status:Needs work» Needs review
StatusFileSize
new879 bytes
new3.35 KB
PASSED: [[SimpleTest]]: [MySQL] 55,790 pass(es).
[ View ]

Well, twig will certainly need some time until it's in.

Status:Needs review» Needs work
Issue tags:-VDC

The last submitted patch, drupal-1998182-9.patch, failed testing.

olli’s picture

olli’s picture

Status:Needs review» Needs work

Tested manually and was about to set this RTBC, but

+++ b/core/modules/views/lib/Drupal/views/Tests/GlossaryTest.php
@@ -55,6 +63,27 @@ public function testGlossaryView() {
+      debug((string) $result[0]);
+      debug(trim(str_replace(array('|', '(', ')'), '', (string) $result[0])));
+      debug($count);

Have to remove these first.

dawehner’s picture

Status:Needs work» Needs review
StatusFileSize
new937 bytes
new3.22 KB
PASSED: [[SimpleTest]]: [MySQL] 55,681 pass(es).
[ View ]

Ups. It would be cool if the testbot would figure that out automatically.

damiankloip’s picture

Status:Needs review» Reviewed & tested by the community
alexpott’s picture

Status:Reviewed & tested by the community» Needs work

Needs reroll due to twig...

dawehner’s picture

Status:Needs work» Needs review
StatusFileSize
new2.36 KB
PASSED: [[SimpleTest]]: [MySQL] 57,459 pass(es).
[ View ]

Let's go.

Status:Needs review» Needs work
Issue tags:-VDC

The last submitted patch, drupal-1998182-16.patch, failed testing.

olli’s picture

Status:Needs work» Needs review
Issue tags:+VDC

#16: drupal-1998182-16.patch queued for re-testing.

olli’s picture

Status:Needs review» Reviewed & tested by the community

Reroll looks good to me.

alexpott’s picture

Status:Reviewed & tested by the community» Fixed

Ran Drupal\views\Tests\GlossaryTest locally passes...

Committed 5b5d535 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.