I tried the latest update on my site with a customized version based on zen classic (had no problems with 2.5) and it resulted in erratic failures making the site essentially unusable. Home page wouldn't display. User login page didn't display, some nodes did display some didn't. I ended up deleting the module and replacing it with 2.5 version which restored normal operation.
Sorry I can't do more intensive investigation right now.
Just a heads up warning.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | wsod.patch | 2.69 KB | johnalbin |
| #13 | wsod.patch | 2.32 KB | johnalbin |
Comments
Comment #1
johnalbinThat's really weird.
I'm not seeing that problem and I'm using the latest ThemeSettingsAPI 5.x-2.6 and Zen 5.x-0.8.
Comment #2
jtjones23 commentedsubscribing
Comment #3
johnalbinJohn, are you seeing this issue too? Since I can't duplicate the problem, any insight would help.
Comment #4
ggevalt commentedThere are two posts relating to Zen issues; I flipped a coin and decided to go here. I can tell you of my experience. We have been running Zen-fixed theme. On our clone site, we decided to develop a new look and used a Roople Theme, News flash as the base. We uploaded Theme Settings API module and made major customizations in the theme and had it to our liking. Things seemed to be OK. HOWEVER, we noticed that the search function was a bit squirrelly, particularly with old material. But no biggee -- this problem was not occurring on the main site.
We imported theme, modified CSS files and Theme Settings API to main site. We set new theme as default. Things seemed OK. We then checked status update and uploaded new version of Theme Settings. Things seemed OK. Then when we logged off and got the dreaded White Screen of Death. Long story short, we discovered problems all day. Went back to Zen and still had problems. Thought maybe it was the NEW verison of Theme Settings that was the problem since new site was worse than clone. So we uploaded older version of Theme Settings. Still problems, though not quite as bad. Then discovered drupal.org post on compatibility problems between Theme Settings and Zen. Disabled Theme Settings API module. Problems disappeared. No matter how hard we tried.
On Main site, we kept older version of Theme Settings, disabled ZEN theme, enabled new theme and activated Theme Settings. Site now seems to be working fine. Could not for the life of us duplicate the problems we had earlier -- mostly in logout and search functions, accessing front page and accessing links that called for taxonomy terms-- we'd often get White Screen of Death and then could not log back on. However, these errors were NOT consistent and were greatly magnified when we cleared cache and cookies. Many site visitors did not seem to have problems and we presume this is because they never logged out and/or never cleared cache or cookies.
Some of the error logs on the server:
[client XX.XXX.XX.XX] PHP Fatal error: Call to undefined function: arg() in /var/www/vhosts/oursite.com/public/sites/all/modules/themesettingsapi/themesettingsapi.module on line 23
[client xxx.xxx.xx.xxx] PHP Fatal error: Call to undefined function: arg() in /var/www/vhosts/oursite.com/public/sites/all/modules/themesettingsapi/themesettingsapi.module on line 19, referer: http://oursite.com/admin/logs/updates
(I've modified the addresses).
CONCLUSIONS: Zen compatability is an issue and new version presents more problems than the old in this respect. There is also the possibility that the new version has a new bug. Sorry, but after spending all day on this, I don't have time to test this out and to determine exactly where the problem is.
I hope this helps. If we see the problem again, we'll update.
geoff gevalt
Comment #5
jtjones23 commentedThe problems I had are the same as geoffs. The line 23 error was with version 5.x-2.6 and the line 19 error was with version 5.x-2.5.
I'm also using a custom zen theme (zen 5.x-0.6) and am attempting to move over to Newsflash. Version 5.x-2.4 seems to work fine with Newsflash and Zen enabled.
Drupal 5.3
Apache 2.2.4
PHP 5.2.4
MySQL 5.0.45
Comment #6
mwpeters commentedAfter disabling and enabling cache to make some other settings I can now agree that a problem exists between zen and 5.x-2.5 as well. Same "white screen of death", but it seemed more ameanable to a workaround and I was able to recover with less damage.
....Or maybe I was just became more prepared with with useful tricks.
I found setting up a muli-site site branch on my install a useful recovery technique. I used the same data-base and the same security cookie domain, but forced a different default theme using a different settings.php. This seemed to work relatively reliably. Interestingly I was even able to get the current 0.8 update to Zen to work in the second site.
Things seemed to process nomrally and nothing shows up in logs, just no screen to work with in the browser.
My problems were with a custom theme built off the 0.6 version of Zen-fixed and having a number of the browser patches from 0.7 Zen-fixed applied.... So its a freak theme, and may have problems..... But still, these failures are closer to catostrophic than gentle, and anything that can be done to lessen such impacts would be very welcome. And based on other forum chatter I gather I'm far from the only one who created a custom look by skinning Zen 0.6 and reworking it a bit.
If I get more time I may investigate this more later, but I lost a bunch of time on it this week already, so it may be a while before I can do that.
Drupal 5.5
Apache 2.x .....(using .htaccess)
PHP 4.4.4 .......(as a server mod)
MySQL 4.1.20
Comment #7
mwpeters commentedMy problems were seen with the 0.6 version of Zen-fixed (+mods)
The 0.8 version has been substantially modified and is a somewhat different animal.
The 0.8 Zen-Classic variation is closer to the 0.6.
I think a lot of designs may have gotten based off the 0.6 vesions since it was among the best starting "builders themes" for quite a while this year.
Mark
Comment #8
catbyte commentedSame problem with YAML Theme www.yaml-fuer-drupal.de with cache turned on. Cache off, everything seems to be fine...
Comment #9
jtjones23 commentedJohn,
I was able to recreate this bug on a new MAMP 1.7.1 installation. I installed Drupal 5.5, Theme API 5.x-2.6, Zen-5.x-0.6 and NewsFlash014. I enabled Zen and NewsFlash. I went to my account and switched from Garland to NewsFlash which works fine. But the moment I log out, WSOD.
To get the site back, I deleted the Theme API module (not a real workaround). If I remove the Zen theme, I can not recreate the WSOD (even with Theme API 5.x-2.6 installed). Hope that helps.
Comment #10
johnalbinZen 5.x-0.6? John, can you recreate the bug when using Zen 5.x-0.8?
I'll try to re-create this on my Mac OS X dev environment later today.
Comment #11
hass commentedSubscribe.
Comment #12
jtjones23 commentedI got the same error message with Zen 5.x-0.8. PHP Fatal error: Call to undefined function arg() in /Applications/MAMP/htdocs/drupal5/sites/all/modules/themesettingsapi/themesettingsapi.module on line 23.
Comment #13
johnalbinI was finally able to reproduce this issue.
If a page is cached, then HOOK_init() is called before DRUPAL_BOOTSTRAP_PATH. Which means arg() and drupal_add_css() are not available to any module code on cached pages.
I'm researching the best method to fix this bug, but those who need a quick fix can revert to 5.x-2.3 or use this tested patch.
Sorry about that everyone!
Comment #14
jtjones23 commentedgreat, I thought I was going crazy when I made another MAMP site that was not getting the WSOD . Of course, I had not turned on caching yet (or read catbyte's reply closely).
Comment #15
johnalbinThis looks like a better solution.
I want to thoroughly test this before releasing 5.x-2.7. So reviews would be appreciated!
Comment #16
jtjones23 commentedpatch #15 applies cleanly...no more WSOD on my MAMP installation (with caching turned on).
Comment #17
hass commented@John: Why in general have you changed the module structure in this different way after 2.3? Speed couldn't be the real only point here. I don't understand why you are trying to back port the menu include logic from D6. Version 2.3 was very good and the module looked *ready* for me without any need to overhaul *anything* in D5 times. Now things got broken in about 4 releases. I would prefer to go back to 2.3 level and keep the module as is except bug fixing.
Comment #18
johnalbinFixed in 5.x-2.7.
Hass, I apologize for introducing a critical bug in 5.x-2.4. But, for 99+% of the page accesses, the optimization converts 3079 characters on 91 lines of parsed code into 287 characters on 17 lines of parsed code. Feel free to use TSAPI 5.x-2.3 instead of 5.x-2.7, if you wish.
Comment #19
johnalbinMaking it easier for users seeing "Fatal Error" to find this issue in the queue.
Comment #20
ggevalt commentedThe question remaining is whether the latest version of theme settings API -- the 2.7 -- has taken care of this issue and whether the latest version of this module is in good working order. I have been keeping the module version at 2.5 out of a concern that the 2.6 version had a bug in addition to the theme incompatibility.
Thoughts?
geoff
Comment #21
johnalbinThe “incompatibility” with Zen was a bug in Zen: http://drupal.org/node/199578
As for your concerns for the stability of TSAPI 2.7, see comment #13, #15, #16 and #18. #16 is John's review of the bug fix.
Comment #22
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.