Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
With distributions becoming more and more ubiquitous, we would like to support using a distribution as core directly from a make file. But Drush Make currently only support pulling a distribution as a profile (using the 'profile-only'
variant), which means that:
- The core patches of the distribution are not going to be applied,
- The distribution is going to be re-built from its make file which is very inefficient and might pull slightly different versions of the dependencies when the distribution is using
-dev
versions or un-anchored external dependencies.
It would be easier to be able to simply do:
api = 2
core = 7.x
projects[commerce_kickstart][type] = core
# Any additional module to fetch.
projects[flag][type] = module
Comments
Comment #1
Damien Tournoud CreditAttribution: Damien Tournoud commentedLuckily, this is not hard to do. Passing the download type to the downloader also allow us to remove one hardcoded check on
"drupal"
.Comment #2
Damien Tournoud CreditAttribution: Damien Tournoud commentedSame patch, with the missing test file.
Comment #3
jonhattanThat's a great thing. It worths three lines in docs/make.txt.
Comment #4
jhedstromThanks Damien. Committed in 61d84f3 to 6.x. Re #3 I've also followed up with a few lines of docs.
Comment #6
anarcat CreditAttribution: anarcat commentedcan we port this to Drush 5?
it turns out we can't *depend* on Drush 6 because that means depending on PHP >= 5.3.5, which means upgrading to PHP 5.4 on Debian wheezy (amongst others), which means dropping support for Drupal 6, which wasn't part of the release goals of Aegir at all.
i'm ready to roll out this patch if you guys are okay with this.
Comment #7
clemens.tolboomI did
git cherry-pick 61d84f321d84d265f65a92b44c504297fefa2737
patch applied clean.I haven't tested it.
Comment #8
jonhattanIt is an incompatible API change. I'm not sure of the real incidence of such a change but we should preserve compatibility.
I think of placing $type as last parameter, and default it to null.
Opinions?
Comment #9
Damien Tournoud CreditAttribution: Damien Tournoud commentedI would argue that those are internal functions to Drush Make.
Comment #10
jhedstromI agree these are internal functions, and am inclined to backport to 5.x. Setting at RTBC for now, and will commit shortly if nobody objects.
Comment #11
moshe weitzman CreditAttribution: moshe weitzman commentedNoone objected so I cherry picked this to 7.x-5.x
Comment #12
kristiaanvandeneyndeWhen using this technique in 7.x-5.x, my make always ends with:
Even sudo doesn't work and sudo can make me a sandwich...
Comment #13
kristiaanvandeneyndeNever mind, it works now (after a reboot?).