The following piece of code does not follow the Coding Standards for indentation.

function user_register_form($form, &$form_state) {
  global $user;

  $admin = user_access('administer users');

  // Pass access information to the submit handler. Running an access check
  // inside the submit function interferes with form processing and breaks
  // hook_form_alter().
  $form['administer_users'] = array(
     '#type' => 'value',
     '#value' => $admin,
  );
CommentFileSizeAuthor
#9 1988456_user_register_form_coding_standard_fix.patch556 bytesgaurav.goyal
#3 update-coding-standard-for-user-module-1988456-2.patch554 byteseltermann
#1 do-1988456-update-coding-standard-for-user-module.patch17.76 KBpvmchau

Comments

pvmchau’s picture

pvmchau commented
Status: Active » Needs review
StatusFileSize
new do-1988456-update-coding-standard-for-user-module.patch17.76 KB

Update coding standards for user.module

thehong’s picture

thehong commented
Status: Needs review » Needs work 
+  
+  // libxml2 ver.2.7.0 - 2.7.2 stripping leading angle brackets bug patch
+  if (
+      LIBXML_DOTTED_VERSION == '2.7.0' ||
+      LIBXML_DOTTED_VERSION == '2.7.1' ||
+      LIBXML_DOTTED_VERSION == '2.7.2' ||
+      (LIBXML_DOTTED_VERSION == '2.7.3' && version_compare(PHP_VERSION, '5.2.9', '<' ))
+  ) {
+    $data = str_replace('&lt;', '&#60;', $data);
+    $data = str_replace('&gt;', '&#62;', $data);
+    $data = str_replace('&amp;', '&#38;', $data);
+  }

I think you should remove those lines.

eltermann’s picture

eltermann commented
Status: Needs work » Needs review
StatusFileSize
new update-coding-standard-for-user-module-1988456-2.patch554 bytes
nkhanh90’s picture

nkhanh90 commented

#3: update-coding-standard-for-user-module-1988456-2.patch queued for re-testing.

parthipanramesh’s picture

parthipanramesh commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Latest patch does apply indentions correctly.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Needs work

Nope, oops... it needs to be two spaces of indentation, not one space :)

lachezar.valchev’s picture

lachezar.valchev commented
Assigned: Unassigned » lachezar.valchev
gaurav.goyal’s picture

gaurav.goyal commented
Assigned: lachezar.valchev » gaurav.goyal
gaurav.goyal’s picture

gaurav.goyal commented
Status: Needs work » Needs review
StatusFileSize
new 1988456_user_register_form_coding_standard_fix.patch556 bytes

Indentation Corrected.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs review » Reviewed & tested by the community

That looks great - thanks!

The bug doesn't appear to be present in Drupal 8 (must have been fixed somewhere along the way).

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 1988456_user_register_form_coding_standard_fix.patch, failed testing.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Reviewed & tested by the community
gaurav.goyal’s picture

gaurav.goyal commented

9: 1988456_user_register_form_coding_standard_fix.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 9: 1988456_user_register_form_coding_standard_fix.patch, failed testing.

David_Rothstein’s picture

David_Rothstein commented
Status: Needs work » Reviewed & tested by the community

Likely testbot glitch - moving back to RTBC.

David_Rothstein’s picture

David_Rothstein commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x - thanks!

  • David_Rothstein committed d1a4193 on 7.x 
    Issue #1988456 by gaurav.goyal, eltermann, pvmchau: Non-standard...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.