Convert user_logout() to a new style controller

also..

meh..this wont fire hooks..something a bit uglier then

humpff, wrong namespace

+++ b/core/modules/user/user.module
@@ -906,11 +907,9 @@ function user_menu() {
@@ -1056,8 +1055,7 @@ function user_menu_site_status_alter(&$menu_site_status, $path) {

@@ -1056,8 +1055,7 @@ function user_menu_site_status_alter(&$menu_site_status, $path) {
   if ($menu_site_status == MENU_SITE_OFFLINE) {
     // If the site is offline, log out unprivileged users.
     if (user_is_logged_in() && !user_access('access site in maintenance mode')) {
-      module_load_include('pages.inc', 'user', 'user');
-      user_logout();
+      UserController::create(Drupal::getContainer())->logout()->send();
     }

This seems very wrong... You should never send() the response yourself.

i know its ugly like i said in #5 but i am open to alternatives!

hmm maybe i should keep user_logout() and fix this in another issue

there, lets keep this issue moving, cause this access check here is needed to several other conversions and fixing openid for drupal_exit removal

WebTestBase--

cant reproduce locally
#10: 1987894-user-logout-route-10.patch queued for re-testing.

+++ b/core/modules/user/lib/Drupal/user/Controller/UserController.phpundefined
@@ -0,0 +1,69 @@
+use Drupal\user\Plugin\Core\Entity\User;

Do we really need this statement? I can't see any usage.

+++ b/core/modules/user/lib/Drupal/user/Access/LoginStatusCheck.phpundefined
index 7e294f5..46745ec 100644
--- a/core/modules/user/lib/Drupal/user/UserAutocompleteController.php

--- a/core/modules/user/lib/Drupal/user/UserAutocompleteController.php
+++ b/core/modules/user/lib/Drupal/user/Controller/UserAutocompleteController.phpundefined

Renaming an existing file feels a bit unrelated though this could make sense.

thanks for the review!

this conflicted with roles commit, so no interdiff, sorry.

i removed the unneeded use statement

Renaming an existing file feels a bit unrelated though this could make sense.

yes i moved cause i just created the directory, i dont think we should have a seperate issue for moving this

Why exactly aren't we removing user_logout(), the function?

because it is needed by user_menu_site_status_alter
it does something hacky, and imo should be converted to an event listener. you cant redirect like that, but fixing this should happen in the RedirectResponse issue

Great, thank you.

Crell opened a nice followup for #15, #16
#1998228: Remove hook_menu_site_status_alter() in favor of request listeners

Committed e21c1a1 and pushed to 8.x. Thanks!