Convert url_alter_test_foo() to a new style controller

conversion patch.

1. +++ b/core/modules/system/tests/modules/url_alter_test/lib/Drupal/url_alter_test/Controller/URLAlterTestController.php
   @@ -0,0 +1,22 @@
   +class URLAlterTestController {
   +  /**
   

   This should have a newline in between.

2. +++ b/core/modules/system/tests/modules/url_alter_test/lib/Drupal/url_alter_test/Controller/URLAlterTestController.php
   @@ -0,0 +1,22 @@
   +    print 'current_path=' . current_path() . ' request_path=' . request_path();
   +    exit;
   

   You should return just a response object.

3. +++ b/core/modules/system/tests/modules/url_alter_test/url_alter_test.module
   @@ -11,17 +11,8 @@
      $items['url-alter-test/foo'] = array(
        'title' => 'Foo',
   -    'page callback' => 'url_alter_test_foo',
   -    'access arguments' => array('access content'),
   +    'route_name' => 'url_alter_test_foo',
        'type' => MENU_CALLBACK,
      );
   

   this hook can be removed as it is, because MENU_CALLBACKs are directly replaced with controllers.

.

Attached patch addresses comments in #5.

+++ b/core/modules/system/tests/modules/url_alter_test/lib/Drupal/url_alter_test/Controller/URLAlterTestController.php
@@ -0,0 +1,24 @@
+   *
+   */

Let's also add a simple @return on there.

Thank you.

Committed 80d9f5c and pushed to 8.x. Thanks!

At some point we need to replace current_path and request_path with stuff based on Symfony's Request object.

+++ b/core/modules/system/tests/modules/url_alter_test/lib/Drupal/url_alter_test/Controller/URLAlterTestController.php
@@ -0,0 +1,26 @@
+    return new Response('current_path=' . current_path() . ' request_path=' . request_path());

I think we should use the Request to get the currecnt path. The function uses drupal_container()->get('request')->attributes->get('_system_path')