Part of #1971384: [META] Convert page callbacks to controllers

For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.

CommentFileSizeAuthor
#15 taxonomy-1987860-15.patch6.93 KBtim.plunkett
#15 interdiff.txt569 bytestim.plunkett
#13 taxonomy-1987860-13.patch6.93 KBtim.plunkett
#10 taxonomy-1987860-10.patch8.26 KBtim.plunkett
#10 interdiff.txt3.72 KBtim.plunkett
#6 taxonomy-1987860-6.patch6.89 KBtim.plunkett
#6 interdiff.txt4.88 KBtim.plunkett
#4 taxonomy-1987860-4.patch4.61 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +MENU_LOCAL_ACTION

Blocks #1908756: Separate Action Links (MENU_LOCAL_ACTION) from hook_menu()

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Postponed

Blocked by #1978166: Convert block/add/{%custom_block_type} to Controller as it has support for default value.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Postponed » Active

Not blocked anymore

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new taxonomy-1987860-4.patch4.61 KB

This needs a new access checker, but I just wanted to get the start of it up.

Status: Needs review » Needs work

The last submitted patch, taxonomy-1987860-4.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt4.88 KB
new taxonomy-1987860-6.patch6.89 KB

Hopefully #2028585: Replace entity_page_create_access by an access controller will replace entity_page_create_access(), but we should continue using it for now.

vijaycs85’s picture

vijaycs85
Location London, UK
commented

looks good to me. RTBC from my side.

andypost’s picture

andypost
he/him
Primary language Russian
commented

#6: taxonomy-1987860-6.patch queued for re-testing.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Great!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new interdiff.txt3.72 KB
new taxonomy-1987860-10.patch8.26 KB

That issue went in.

This will fail without #2031115: Language::LANGUAGE_DEFAULT should be Language::LANGCODE_DEFAULT

Status: Needs review » Needs work
Issue tags: -WSCCI-conversion, -MENU_LOCAL_ACTION

The last submitted patch, taxonomy-1987860-10.patch, failed testing.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs work » Needs review
Issue tags: +WSCCI-conversion, +MENU_LOCAL_ACTION

#10: taxonomy-1987860-10.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new taxonomy-1987860-13.patch6.93 KB

That went in.

dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Access/TaxonomyTermCreateAccess.phpundefined
@@ -0,0 +1,34 @@
+ * Contains Drupal\taxonomy\Access\TaxonomyTermCreateAccess.

Missing "\"

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new interdiff.txt569 bytes
new taxonomy-1987860-15.patch6.93 KB

:)

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect

Status: Reviewed & tested by the community » Needs work
Issue tags: -WSCCI-conversion, -MENU_LOCAL_ACTION

The last submitted patch, taxonomy-1987860-15.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
Issue tags: +WSCCI-conversion, +MENU_LOCAL_ACTION

#15: taxonomy-1987860-15.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

HEAD was broken #2024833: Adopt load() and loadMultiple() on entity storage controllers

yesct’s picture

yesct commented
Issue tags: +RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 67ffbd3 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

andypost’s picture

andypost
he/him
Primary language Russian
commented

Follow-up clean-up #2068287: Support bundle names provided in the request arguments in EntityCreateAccessCheck