Convert error_test module to a new style controller

attached patch converts all routes in error_test module and fixes the error messages the tests are looking for.

attached patch with interdiff fixes remaining test failures.

+++ b/core/modules/system/tests/modules/error_test/lib/Drupal/error_test/Controllers/ErrorTestController.php
@@ -0,0 +1,68 @@
+class ErrorTestController implements ControllerInterface {
...
+  /**
+   * Constructs a UpdateTestController object.
+   *
+   * @param \Drupal\Core\Config\ConfigFactory $config_factory
+   *   The factory for configuration objects.
+   */
+  public function __construct(Connection $database) {
+    $this->database = $database;
+  }

Let's simply extend the ControllerBase, so need for this boilerplate for tests.

renamed Controllers -> Controller.
Removed boilerplate in favor of $this->container->get

Attached patch fixes missing ;

Forgot error handlers were keying off of the class name. That's fixed too now.

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/SimpleTestErrorCollectorTest.php
@@ -94,6 +95,7 @@ protected function error($message = '', $group = 'Other', array $caller = NULL)
+    $this->verbose(print_r($error,TRUE));

Let's remove that :)

removed!

+++ b/core/modules/system/lib/Drupal/system/Tests/Common/SimpleTestErrorCollectorTest.php
@@ -94,6 +94,7 @@ protected function error($message = '', $group = 'Other', array $caller = NULL)
+    $this->verbose(print_r($error,TRUE));

There is one more.

removed!

Quick, before core changes again. :-)

#18: drupal8.error_test.1987700-18.patch queued for re-testing.

Committed and pushed to 8.x. Thanks!