The PHP module uses the BLOCKQUOTE tag to indent some text in its help text. This should be fixed, especialy since we want to reserve this tag solely for quoting purposes.

See q=filter/tips

Anybody has an idea what to use instead of this tag?

CommentFileSizeAuthor
#2 phpmodule2.diff1.86 KBmooffie
#1 phpmodule1.diff2.11 KBmooffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mooffie’s picture

mooffie CreditAttribution: mooffie commented
Status: Active » Needs review
FileSize
phpmodule1.diff2.11 KB

Here's a patch. I split the code snippet into two list items. Are we past string freeze already? :-(

mooffie’s picture

mooffie CreditAttribution: mooffie commented
FileSize
phpmodule2.diff1.86 KB

Here's an alternative patch. This one simply removes the BLOCKQUOTE tag so it evades the string freeze because it doesn't touch any translatable string. I think the previous patch is nicer, though.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed

No, we are not past string freeze yet, and we broke several strings in parts so that they are easier to translate (as compared to being a big block of text), so I committed #1. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.