EditorManager's AlterDecorator calls hook_edit_editor_alter() but there are no docs for it.

Files: 
CommentFileSizeAuthor
#4 edit_api_php-1984628-3.patch1.1 KBWim Leers
PASSED: [[SimpleTest]]: [MySQL] 56,046 pass(es).
[ View ]
#4 interdiff.txt850 bytesWim Leers
#2 edit_api_php-1984628-1.patch1.01 KBWim Leers
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Comments

Wim Leers’s picture

Thanks for reporting! Will fix.

Wim Leers’s picture

Assigned:Unassigned» Wim Leers
Status:Active» Needs review
Issue tags:+sprint, +in-place editing, +Spark
StatusFileSize
new1.01 KB
FAILED: [[SimpleTest]]: [MySQL] Repository checkout: failed to checkout from [git://git.drupal.org/project/drupal.git].
[ View ]

Inspired by hook_field_widget_info_alter() docs in field.api.php.

Note: docs are missing for pretty much every alter hook that is powered by AlterDecorator.

tim.plunkett’s picture

+++ b/core/modules/edit/edit.api.phpundefined
@@ -0,0 +1,30 @@
+ * but before they are cached. Hence any any alterations will be cached.

This should also @see the Editor specific annotation. Does that exist yet? If not, please make sure that issue does it.

+++ b/core/modules/edit/edit.api.phpundefined
@@ -0,0 +1,30 @@
+  $editors['editor']['class'] = 'Drupal\\advanced_editor\\Plugin\\edit\\editor\\AdvancedEditor';

Unless you're using double quotes, the double slashes are overkill :)

Wim Leers’s picture

StatusFileSize
new850 bytes
new1.1 KB
PASSED: [[SimpleTest]]: [MySQL] 56,046 pass(es).
[ View ]

This should also @see the Editor specific annotation. Does that exist yet? If not, please make sure that issue does it.

Issue for that is RTBC: #1987140: Add a dedicated @InPlaceEditor plugin annotation.

Unless you're using double quotes, the double slashes are overkill :)

Hah! SublimeText fail!

tim.plunkett’s picture

Status:Needs review» Reviewed & tested by the community

Awesome, thanks.

Status:Reviewed & tested by the community» Needs work
Issue tags:-sprint, -Plugin system, -in-place editing, -Spark

The last submitted patch, edit_api_php-1984628-3.patch, failed testing.

tim.plunkett’s picture

Status:Needs work» Needs review
Issue tags:+sprint, +Plugin system, +in-place editing, +Spark

#4: edit_api_php-1984628-3.patch queued for re-testing.

tim.plunkett’s picture

Status:Needs review» Reviewed & tested by the community

Grr.

Dries’s picture

Status:Reviewed & tested by the community» Fixed

Committed to 8.x. Thanks! Btw, I fixed the 'any any' prior to committing it.

Wim Leers’s picture

Issue tags:-sprint

Hah, we both missed that apparently. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.