@see Title.

This is completely unnecessary and weird:

if (!in_array('Drupal\Core\FileTransfer\ChmodInterface', class_implements(get_class($this)))) {
...
}
CommentFileSizeAuthor
#1 instanceof-1983136-1.patch684 bytesfubhy

Comments

fubhy’s picture

fubhy commented
Status: Active » Needs review
StatusFileSize
new instanceof-1983136-1.patch684 bytes
enhdless’s picture

enhdless commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Patch works great.

chx’s picture

chx commented

That's really weird. The patch is correct but did you run git blame ; did you look why such a weird thing was done?

fubhy’s picture

fubhy commented

1: instanceof-1983136-1.patch queued for re-testing.

fubhy’s picture

fubhy commented

That's really weird. The patch is correct but did you run git blame ; did you look why such a weird thing was done?

Nope, didn't do that yet. I guess I thought it was just overlooked at some point in a larger patch. Git blame reveals that it was moved in https://drupal.org/node/1323124 and originally implemented in https://drupal.org/node/602520 which was in 2009. That issue doesn't really explain why it was implemented like this specifically. It's a short issue with quick commit and only 3 people involved so maybe that (and lacking OO experience back in 2009) is the reason ;).

chx’s picture

chx commented

Yes, that sounds correct, thanks for looking. I am always curious when something is out of line -- either maybe there was a reason (we know PHP is ...) or maybe there are other instances but neither seems to be case so we are good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Nice clean-up!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.