Use 'instanceof' instead of class_implements() in \Drupal\Core\FileTransfe\FileTransfer. [#1983136]

Comment	File	Size	Author
#1	instanceof-1983136-1.patch	684 bytes	fubhy

File	Size
instanceof-1983136-1.patch	684 bytes

Comment #2

enhdless CreditAttribution: enhdless commented 16 December 2013 at 00:28

Issue summary:	View changes
Status:	Needs review	» Reviewed & tested by the community

Patch works great.

Log in or register to post comments

Comment #3

chx CreditAttribution: chx commented 16 December 2013 at 00:40

That's really weird. The patch is correct but did you run git blame ; did you look why such a weird thing was done?

Log in or register to post comments

Comment #4

fubhy CreditAttribution: fubhy commented 16 December 2013 at 06:46

1: instanceof-1983136-1.patch queued for re-testing.

Log in or register to post comments

Comment #5

fubhy CreditAttribution: fubhy commented 16 December 2013 at 07:00

That's really weird. The patch is correct but did you run git blame ; did you look why such a weird thing was done?

Nope, didn't do that yet. I guess I thought it was just overlooked at some point in a larger patch. Git blame reveals that it was moved in https://drupal.org/node/1323124 and originally implemented in https://drupal.org/node/602520 which was in 2009. That issue doesn't really explain why it was implemented like this specifically. It's a short issue with quick commit and only 3 people involved so maybe that (and lacking OO experience back in 2009) is the reason ;).

Log in or register to post comments

Comment #6

chx CreditAttribution: chx commented 17 December 2013 at 13:40

Yes, that sounds correct, thanks for looking. I am always curious when something is out of line -- either maybe there was a reason (we know PHP is ...) or maybe there are other instances but neither seems to be case so we are good.