db_type_map() should use base type names, not aliases [#198234]

The db_type_map() function for mysql declares that the Schema API type 'numeric' maps to the mysql type 'numeric'. This works fine, but mysql treats 'numeric' as an alias for its native type 'decimal'. Thus, if you create a column with a Schema API type of 'numeric', when schema.module inspects the database, mysql says the column is of type 'decimal', and schema.module reports an error where none exists.

I can work around this in schema.module but the right solution is to use the correct native type name in core. Trivial patch attached.

Comment	File	Size	Author
#3	mysql-numeric-type-198234-3.patch	1.27 KB	bjaspan
#3
	mysql-numeric-type.patch	664 bytes	bjaspan

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

bjaspan CreditAttribution: bjaspan commented 5 December 2007 at 23:41

I left out a step in my explanation.

When schema.module inspects the database and learns that table foo column bar is of type 'decimal', it looks through the results of db_type_map() for which Schema API data type maps to the mysql type 'decimal'. It doesn't find one (because currently the type map lists 'numeric'), and reports an error.

Comment #2

hass CreditAttribution: hass commented 6 December 2007 at 01:49

subscribe :-)

Comment #3

bjaspan CreditAttribution: bjaspan commented 21 December 2007 at 18:19

Title:

mysql type for 'numeric' is called DECIMAL

» db_type_map() should use base type names, not aliases

File	Size
mysql-numeric-type-198234-3.patch	1.27 KB

Exactly the same problem exists with pgsql's Schema type char:normal. It maps to 'char' but should map to 'character'. Again, worked around in schema.module but should be fixed in core.

New patch attached.