Comments

andypost’s picture

Status:Active» Needs review
Issue tags:+Novice, +API clean-up, +Config novice
StatusFileSize
new3.16 KB
FAILED: [[SimpleTest]]: [MySQL] 55,614 pass(es), 3 fail(s), and 0 exception(s).
[ View ]
new3.16 KB
FAILED: [[SimpleTest]]: [MySQL] 55,421 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
new3.16 KB
FAILED: [[SimpleTest]]: [MySQL] 55,972 pass(es), 2 fail(s), and 0 exception(s).
[ View ]
new3.16 KB
FAILED: [[SimpleTest]]: [MySQL] 55,935 pass(es), 2 fail(s), and 0 exception(s).
[ View ]

Let's see how bots will pass...
Extended test would be reverted in #1893442-6: Move BlockStorageController::loadByProperties() into ConfigStorageController

andypost’s picture

StatusFileSize
new24.29 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
new24.29 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
new24.29 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
new24.29 KB
FAILED: [[SimpleTest]]: [MySQL] Setup environment: Test cancelled by admin prior to completion.
[ View ]
new2.34 KB

Changed comparison to allow debug also I think this easy to understand

andypost’s picture

StatusFileSize
new4.52 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981418-voc-sort-2_6.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new4.52 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981418-voc-sort-2_5.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new4.52 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981418-voc-sort-2_4.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]
new4.52 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981418-voc-sort-2_3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

Was wrong patch (locally pass randomly)

Status:Needs review» Needs work

The last submitted patch, 1981418-voc-sort-2.patch, failed testing.

andypost’s picture

This bug also affects in #1868772-86: Convert filters to plugins

alweb’s picture

Status:Needs work» Needs review
Issue tags:-Novice, -API clean-up, -Config novice

#3: 1981418-voc-sort-2.patch queued for re-testing.

alweb’s picture

#3: 1981418-voc-sort-2.patch queued for re-testing.

alweb’s picture

#3: 1981418-voc-sort-2.patch queued for re-testing.

alweb’s picture

#3: 1981418-voc-sort-2.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +API clean-up, +Config novice

The last submitted patch, 1981418-voc-sort-2.patch, failed testing.

alweb’s picture

Status:Needs work» Needs review
StatusFileSize
new4.67 KB
FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch 1981418-voc-sort-3.patch. Unable to apply patch. See the log in the details link for more information.
[ View ]

re-rolling

Status:Needs review» Needs work
Issue tags:-Novice, -API clean-up, -Config novice

The last submitted patch, 1981418-voc-sort-3.patch, failed testing.

javisr’s picture

Status:Needs work» Needs review

#11: 1981418-voc-sort-3.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +API clean-up, +Config novice

The last submitted patch, 1981418-voc-sort-3.patch, failed testing.

andypost’s picture

Issue tags:+Needs reroll

patch needs re-roll

dsdeiz’s picture

Status:Needs work» Needs review
StatusFileSize
new4.09 KB
FAILED: [[SimpleTest]]: [MySQL] 57,846 pass(es), 1 fail(s), and 0 exception(s).
[ View ]

Re-rolling. Didn't test locally thought. Can't get simpletest to work. I'll probably give the bot a try.

OT: How do I create an interdiff when re-rolling patches?

Status:Needs review» Needs work

The last submitted patch, 1981418-16-voc-sort.patch, failed testing.

pcambra’s picture

StatusFileSize
new5.33 KB
FAILED: [[SimpleTest]]: [MySQL] 58,054 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
new2.2 KB

Ignore this patch

pcambra’s picture

Status:Needs work» Needs review
StatusFileSize
new4.08 KB
FAILED: [[SimpleTest]]: [MySQL] 58,155 pass(es), 1 fail(s), and 0 exception(s).
[ View ]
new974 bytes

Here's a re-roll with a minor fix on taxonomy load, it should pass now.

Status:Needs review» Needs work

The last submitted patch, 1981418-19-voc-sort.patch, failed testing.

pwieck’s picture

Issue tags:-Needs reroll

Removing tag. Still applies to current head

andypost’s picture

Status:Needs work» Needs review
Issue tags:-Novice, -API clean-up, -Config novice

#19: 1981418-19-voc-sort.patch queued for re-testing.

Status:Needs review» Needs work
Issue tags:+Novice, +API clean-up, +Config novice

The last submitted patch, 1981418-19-voc-sort.patch, failed testing.

tim.plunkett’s picture

Status:Needs work» Needs review
StatusFileSize
new3.72 KB
PASSED: [[SimpleTest]]: [MySQL] 58,055 pass(es).
[ View ]

That failing assertion is useless. It tests a behavior that doesn't exist. It just arbitrarily sorts and tests the arbitrary sort.

andypost’s picture

Removal of the test means that we have no tests for default sorting order for configurables ConfigEntityListController::load()

#1893442: Move BlockStorageController::loadByProperties() into ConfigStorageController added the check for load_by_properties()

Also that means that out default sorting for configurables is fragile

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/VocabularyUnitTest.phpundefined
@@ -120,20 +120,12 @@ function testTaxonomyVocabularyLoadMultiple() {
-    // Fetch all of the vocabularies using taxonomy_vocabulary_load_multiple().
-    // Confirm that the vocabularies are ordered by weight.
-    $vocabularies = taxonomy_vocabulary_load_multiple();
-    taxonomy_vocabulary_sort($vocabularies);

Patch in #3 shows that this leads to random failures, so I cant rtbc it

tim.plunkett’s picture

The testing for default ordering belongs with config_test then, lets move the coverage there.

vijaycs85’s picture

Issue tags:-Novice, -Config novice

Updating tags, as it doesn't sounds like novice issue anymore.

andypost’s picture

Issue summary:View changes
Status:Needs review» Reviewed & tested by the community
StatusFileSize
new3.92 KB
PASSED: [[SimpleTest]]: [MySQL] 63,657 pass(es).
[ View ]

The function is not used and sorting happens in list controller so re-roll of last patch

xjm’s picture

No real need for a change record here since the function didn't exist in D7.

catch’s picture

Status:Reviewed & tested by the community» Fixed

Committed/pushed to 8.x, thanks!

Status:Fixed» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.