tasks sometimes are marked as running when they have in fact crashed

From what I can tell, this results in a task remaining queued in the case of a parse error in Drush code. I think this is acceptable, since the error is blocking the queue from running more than resulting in an error in the actual task.

Perhaps there's another way to replicate this error?

In #2027269: warnings and errors in front-end pre- and post- hooks are ignored for task status, I removed a vbo operation for 'delete-backups' since it'll need special handling to provide it a specific backup to delete. Interestingly, it fails with a missing parameter, and results in the symptom this issue is about. I may re-introduce some of that code in order to replicate this issue conveniently.

I moved log parsing and status updates from #2027269: warnings and errors in front-end pre- and post- hooks are ignored for task status to separate functions and call them from a shutdown function now. It probably already fixes this issue, but I'm thinking of also implementing a button like 'retry' to allow updating the status of a stuck task. That would presumably also allow us to fix already run tasks without having to re-run them.

I tested the 'delete-backups' operation to make a task get stuck, and it doesn't appear to get stuck any longer, but rather fails as it should. I also added an 'update status' button to tasks that do still manage to get stuck in HOSTING_TASK_PROCESSING.

The shutdown hook has a side effect....

$drush updatedb
register_shutdown_function(): Invalid shutdown callback '_hosting_task_update_status' passed hosting_task.drush.inc:12 [warning]
The following updates are pending:

..........

Do you wish to run all pending updates? (y/n): n
Aborting.

I guess that the task/hosting_task.module is not loaded at this point.

Yeah, in fd6b1e9 I had wrapped the register_shutdown_function() in a function_exists() call. This fixed it for me, but re-open if you see this happening anywhere else.

When you CTRL+C a running queued I get this warning:

Finished executing task.                                                                                                              [notice]
Going to sleep for 2 seconds after completing task.                                                                                   [notice]


^CWD hosting_queued: Received signal 2, waiting for children to die.                                                                    [notice]
WD hosting_queued: Stopped daemon                                                                                                     [notice]
Drush command terminated abnormally due to an unrecoverable error.                                                                 [error]
Trying to get property of non-object hosting_task.module:1302                                                                         [notice]
Updated task status to "Successful"                 

This patch fixed it.

nice!

Committed as a3845f4