The Delete link is named cancel. We need to fix this. Normally in admin/people the link is named Delete user. If I install admin_views a delete link is shown and the naming bug has shown to me.

Before
2013-04-19_001213_before.png

After:
2013-04-19_001213_after.png

CommentFileSizeAuthor
#22 Issue-1974208-by-hass-User-delete-link-improperly-na.patch939 byteshass
#21 Issue-1974208-by-hass-User-delete-link-improperly-na.patch946 byteshass
#16 views_User-delete-link-improperly-named-1974208-16.patch803 bytescyberschorsch
#12 cancel1.png20.1 KBdawehner
#9 cancel.png23.69 KBdawehner
#4 views_User-delete-link-improperly-named-D73_oldEGit.patch933 byteshass
#1 views_User-delete-link-improperly-named-D73.patch932 byteshass
#5 views_User-delete-link-improperly-named-D8_oldEGit.patch968 byteshass

Comments

hass’s picture

hass commented
Title: User "delete" link improperly named "cancel" » User delete link improperly named
Version: 8.x-3.x-dev » 7.x-3.x-dev
StatusFileSize
new views_User-delete-link-improperly-named-D73.patch932 bytes

D7 patch attached. I do not change the incorrect capitalization of this action link for now.

EDIT: SUXXX Egit 2.2.0

Version: 8.x-3.x-dev » 7.x-3.x-dev
Assigned: Unassigned »
Status: Active » Needs work

The last submitted patch, views_User-delete-link-improperly-named-D73.patch, failed testing.

hass’s picture

hass commented
Title: User delete link improperly named » User "delete" link improperly named "cancel"
Status: Needs work » Needs review
hass’s picture

hass commented
Title: User delete link improperly named » User "delete" link improperly named "cancel"
StatusFileSize
new views_User-delete-link-improperly-named-D73_oldEGit.patch933 bytes

EDIT: Egit 1.0.0

hass’s picture

hass commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
StatusFileSize
new views_User-delete-link-improperly-named-D8_oldEGit.patch968 bytes

And here the D8 patch.

hass’s picture

hass commented
Issue summary: View changes

A

hass’s picture

hass commented
Project: Views (for Drupal 7) » Drupal core
Version: 7.x-3.x-dev » 8.x-dev
Component: Code » views.module
hass’s picture

hass commented
Status: Needs review » Active
hass’s picture

hass commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new cancel.png23.69 KB

Normally in admin/people the link is named Delete user.

Are you sure about that, from my perspective everything in drupal talks about canceling an account?

dawehner’s picture

dawehner
Primary language German
commented

Just a tip, don't use egit. It's obvious that you run into issues, which doesn't allow you to be productive :)

hass’s picture

hass commented

If you go into the edit form of a user, on the bottom we named the button "delete account" or something like this. We should be consistent. I have never read a button or link named cancel. Where is it named this way?

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new cancel1.png20.1 KB

Cool, so you tell me that you didn't had a look at it at all :)

dawehner’s picture

dawehner
Primary language German
commented

To be honest, this feels like a won't fix, please proove me wrong.

hass’s picture

hass commented

"Cancel account" has context. "Cancel" alone not. Cancel alone cannot translated properly. At very minimum we need to add a context.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work

So. It seems to be okay to use "Cancel account" here.

cyberschorsch’s picture

cyberschorsch
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new views_User-delete-link-improperly-named-1974208-16.patch803 bytes

Cancel account makes way more sense than just "delete" or "cancel" since it is consistent through the user administration process.

dawehner’s picture

dawehner
Primary language German
commented
Assigned: » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +VDC

Thanks!!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: User "delete" link improperly named "cancel" » Rename "Cancel" to "Cancel account" to help translators.
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

yesct’s picture

yesct commented

I looked around, to see if it was really cancel.
Yep: admin/config/people/accounts

What's the history here? Why do we call it cancel?
#8-168: Let users cancel their accounts

Ah issue 8.

Because cancel does not always mean delete:

When cancelling a user account
Disable the account and keep its content.
Disable the account and unpublish its content.
Delete the account and make its content belong to the Anonymous user.

hass’s picture

hass commented
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 7.x-3.x-dev
Component: views.module » User interface
Status: Fixed » Patch (to be ported)

Thx for the change. Are we able to backport this to D7, please?

hass’s picture

hass commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new Issue-1974208-by-hass-User-delete-link-improperly-na.patch946 bytes
hass’s picture

hass commented
StatusFileSize
new Issue-1974208-by-hass-User-delete-link-improperly-na.patch939 bytes
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

Committed to 7.x-3.x
Thanks

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

A