There are two patches used in the panopoly_wysiwyg.make which include binary data stored in a special git format:

libraries[tinymce][patch][1561882] = http://drupal.org/files/1561882-cirkuit-theme-tinymce-3.5.8.patch
libraries[markitup][patch][1715642] = http://drupal.org/files/1715642-adding-html-set-markitup-editor.patch

If the patches are applied via "git apply" the binary files (images) get created perfectly fine!

However, "drush make" appears to use "patch" or something else which doesn't support the git binary patch format, so the patches won't full apply.

I'm not sure what the solution is! Of course, it'd be great for those patches to be accepted upstream. But in the meantime, it's not possible to build a correct Panopoly via "drush make". :-/

Comments

populist’s picture

populist commented
Project: Panopoly WYSIWYG » Panopoly
Status: Active » Postponed (maintainer needs more info)

Which version of Drush are you using? I am able to build Panopoly correctly using the latest Drush.

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Drush 5.8. I see that 5.9 just came out (the day after I submitted this issue ;-))! When I have a chance, I'll try again with 5.9 and let you know.

Désiré’s picture

Désiré commented
Status: Postponed (maintainer needs more info) » Needs review

You should create the patch with --binary and --full-index arguments

git diff --binary --full-index
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Tried with Panopoly 1.0-rc4 and drush 5.9 - it's working fine now!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.