I'm noticing a couple mistakes and inconsistencies in the error messages shown by this module:
-
Perhaps this only applies to American English, so sorry if this is simply a case of my own ignorance, but the error messages for the
max_lengthandmax_wordsvalidators seem grammatically incorrect.Before:
%item can be maximum %num characters long
After:%item can be at most %num characters long - There seems to be inconsistent use of "should be", "must be", "has/have to", etc. I tried to standardize this where possible.
- Most error messages do not end in a period. Drupal core's error messages do, and it seems like this module's should as well.
Patch forthcoming.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | webform_validation-grammar-1972144-1.patch | 9.77 KB | theunraveler |
Comments
Comment #1
theunraveler commentedComment #2
liam morlandhttp://drupalcode.org/project/webform_validation.git/commitdiff/7e8fa64
Thanks very much.
Comment #3
liam morlandComment #3.0
liam morlandAdding code blocks around error messages
Comment #4
liam morlandDrupal 6 is no longer supported.