SearchExcerptTestCase should be a DrupalWebTestCase [#1970588]

SearchExcerptTestCase cannot be a UnitTest because it tries to invoke preprocess handlers (via search_simplify_excerpt_match) that need a hit to the db on module_list.

Attached patch converts SearchExcerptTestCase to a DrupalWebTestCase and corrects the snippet test on $longtext.

While similar warnings (Illegal string offset 'filename' on module_list 74) occur on SearchExpressionInsertExtractTestCase the root cause there is a bug in how module_list handles its fixed_list parameter. This is being discussed in #1563620: All unit tests blow up with a fatal error.

Comment	File	Size	Author
	fix_search_excerpt_test.patch	1.33 KB	heine

Comments

Comment #1

heine commented 15 April 2013 at 10:39

Status:

Active

» Needs review

Comment #2

jhodgdon

she/her

English

commented 6 September 2013 at 22:17

Status:

Needs review

» Needs work

OK. This patch also has a fix that needs to get into the D8 excerpt test:

     $longtext = str_repeat($text . ' ', 10);
-    $result = preg_replace('| +|', ' ', search_excerpt('nothing', $text));
+    $result = preg_replace('| +|', ' ', search_excerpt('nothing', $longtext));
     $this->assertTrue(strpos($result, $expected) === 0, 'When keyword is not found in long string, return value starts as expected');

But in D8 the Excerpt test is a web test, so this issue as titled is D7 only.

I'll file a separate issue for that other fix, and let's take it out of this patch for D7.
#2083773: SearchExcerpt test has a small problem