Meta: #1966246: [meta] Introduce specific annotations for each plugin type

CommentFileSizeAuthor
#17 image-1969708-17.patch4.6 KBtim.plunkett
#16 image_toolkit-1969708-16.patch4.47 KBdawehner
#13 drupal-1969708-13.patch4.46 KBdawehner
#10 drupal-1969708-10.patch4.46 KBdawehner
#10 interdiff.txt963 bytesdawehner
#8 drupal-1969708-8.patch3.52 KBdawehner
#6 drupal-1969708-6.patch4.62 KBdawehner
#6 interdiff.txt1013 bytesdawehner
#5 drupal-1969708-5.patch4.65 KBdawehner
#3 drupal-1969708-3.patch3.7 KBdawehner
#3 interdiff.txt780 bytesdawehner
#1 drupal-1969708-1.patch4.61 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new drupal-1969708-1.patch4.61 KB

I choosed ImageToolKit instead of SystemImageToolKit, just because it felt easier for the developer.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

ImageToolkit I think, not ImageToolKit

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new interdiff.txt780 bytes
new drupal-1969708-3.patch3.7 KB

I agree.

dawehner’s picture

dawehner
Primary language German
commented

Well, the interdiff is not really helpful.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new drupal-1969708-5.patch4.65 KB

There has been a missing file ... again.

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new interdiff.txt1013 bytes
new drupal-1969708-6.patch4.62 KB

Fixed the code in the manager.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Add a dedicated annotation for imagetoolkit plugins » Add a dedicated annotation for @ImageToolkit plugins
Issue tags: +Plugin system, +Annotation
dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new drupal-1969708-8.patch3.52 KB

Rerolled against recent changes

Status: Needs review » Needs work

The last submitted patch, drupal-1969708-8.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt963 bytes
new drupal-1969708-10.patch4.46 KB

Let's fix it.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Issue tags: -Plugin system, -Annotation

#10: drupal-1969708-10.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Plugin system, +Annotation

The last submitted patch, drupal-1969708-10.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new drupal-1969708-13.patch4.46 KB

Just a rerole.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: -Plugin system, -Annotation

#13: drupal-1969708-13.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Plugin system, +Annotation

The last submitted patch, drupal-1969708-13.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new image_toolkit-1969708-16.patch4.47 KB

Rerolled.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new image-1969708-17.patch4.6 KB

Straight reroll, RTBC.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 4784baf and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.