Convert token.inc to a service

Service probably makes sense since we'd want to inject the ModuleHandler and eventually caching as well.

tagging

- If we're using a service, we can't use static methods anymore. Needs to be all regular function calls.
- Needs to be registered at /Drupal::Token for shorthand and DX

+++ b/core/lib/Drupal/Core/Utility/Token.phpundefined
@@ -0,0 +1,291 @@
+    $data = &drupal_static(__FUNCTION__);

Using __FUNCTION__ here means that this static will be stored as 'info' which is not desired. We should manually use 'token_info' as the static key instead of __FUNCTION__ until we replace this with injected caching.

Crazy thought, what if instead of having to declare \Drupal::token() in every instance of hook_tokens and hook_tokens_alter(), what if we passed $this into the hook as well?

looks very good to me:)
just one biggie and two minors

+++ b/core/lib/Drupal/Core/Utility/Token.phpundefined
@@ -0,0 +1,291 @@
+    $data = &drupal_static('token_info');

why not turn this into a class property? Then we could unit test it

+++ b/core/lib/Drupal/Core/Utility/Token.phpundefined
@@ -0,0 +1,291 @@
+  function __construct(ModuleHandlerInterface $module_handler) {

should be public function

+++ b/core/modules/action/action.moduleundefined
@@ -581,7 +581,7 @@ function action_send_email_action($entity, $context) {
+  $recipient = \Drupal::token()->replace($context['recipient'], $context);

@@ -647,7 +647,7 @@ function action_message_action(&$entity, $context = array()) {
+  $context['message'] = \Drupal::token()->replace(filter_xss_admin($context['message']), $context);

@@ -688,11 +688,11 @@ function action_goto_action_submit($form, $form_state) {
+  drupal_goto(\Drupal::token()->replace($context['url'], $context));

+++ b/core/modules/comment/comment.tokens.incundefined
@@ -103,6 +103,8 @@ function comment_token_info() {
+  $token_service = \Drupal::token();

+++ b/core/modules/file/file.field.incundefined
@@ -352,18 +352,19 @@ function file_field_widget_upload_validators($field, $instance) {
+  $destination = \Drupal::token()->replace($destination, $data);

+++ b/core/modules/link/link.moduleundefined
@@ -362,7 +362,7 @@ function link_field_formatter_view(EntityInterface $entity, $field, $instance, $
+      $link_title = \Drupal::token()->replace($item['title'], array($entity->entityType() => $entity), array('sanitize' => FALSE, 'clear' => TRUE));

+++ b/core/modules/node/node.tokens.incundefined
@@ -90,6 +90,8 @@ function node_token_info() {
+  $token_service = \Drupal::token();

+++ b/core/modules/statistics/statistics.tokens.incundefined
@@ -32,6 +32,8 @@ function statistics_token_info() {
+  $token_service = \Drupal::token();

+++ b/core/modules/system/system.api.phpundefined
@@ -3225,6 +3227,8 @@ function hook_url_outbound_alter(&$path, &$options, $original_path) {
+  $token_service = \Drupal::token();

+++ b/core/modules/system/system.moduleundefined
@@ -3591,10 +3591,12 @@ function system_cron() {
+  $token_service = \Drupal::token();

+++ b/core/modules/taxonomy/taxonomy.tokens.incundefined
@@ -89,6 +89,8 @@ function taxonomy_token_info() {
+  $token_service = \Drupal::token();

+++ b/core/modules/user/user.moduleundefined
@@ -1731,6 +1731,7 @@ function user_view_multiple($accounts, $view_mode = 'full', $langcode = NULL) {
+  $token_service = \Drupal::token();

+++ b/core/modules/user/user.tokens.incundefined
@@ -62,6 +62,8 @@ function user_token_info() {
+  $token_service = \Drupal::token();

+++ b/core/modules/views/views.tokens.incundefined
@@ -67,6 +67,8 @@ function views_token_info() {
+  $token_service = \Drupal::token();

No need to prefix Drupal in procedural, non namespaced code

Thanks! looks really good now:)

+++ b/core/lib/Drupal/Core/Utility/Token.phpundefined
@@ -0,0 +1,313 @@
+  protected $moduleHandler = NULL;

we dont do this elsewhere in core.
protected $moduleHandler;
should be enough

+++ b/core/lib/Drupal/Core/Utility/Token.phpundefined
@@ -0,0 +1,313 @@
+   * @return NULL
...
+   * @return NULL

same here..you can completely remove the @return

besides those this seems ready to fly, good job!

Attaching the diff with all whitespace changes removed of the new Token class and token.inc... all changes look good to me. And this patch completely converts all usages. Nice!

Committed c014519 and pushed to 8.x.Thanks!

Untagging. Please remove the tag when the change notification task is completed.