Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
tour.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
11 Apr 2013 at 07:20 UTC
Updated:
29 Jul 2014 at 22:09 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
tim.plunkettThis incorporates the patch from #1967420: Allow Core\AnnotatedClassDiscovery to pass all parameters to the constructor of Component\AnnotatedClassDiscovery
Comment #2
tim.plunkettHere's just the changes for this issue.
Comment #3
tim.plunkettWell, why bother with a one-off discovery that is not reusable?
Comment #4
tim.plunkettThat other patch went in.
Comment #5
tim.plunkettTagging.
Comment #6
dawehnerA general point I want to raise here: This removes the possiblity to override the tour module, by putting it into /modules instead of /core/modules. I'm not sure whether this is still possible at the moment in D8, but it was certainly in previous time.
Comment #7
eclipsegc commentedOverriding the Manager class should still be possible, and if that's possible, then this line can be changed. No?
Eclipse
Comment #8
tim.plunkett#4: tip-1967406-4.patch queued for re-testing.
Comment #10
tim.plunkett#4: tip-1967406-4.patch queued for re-testing.
Comment #11
dawehnerOverriding the Manager class should still be possible, and if that's possible, then this line can be changed. No?
Sure but do you expect that you can't move drupal modules but you require to alter the manager? What about using basename or __DIR__ or something like that here?
Comment #12
tim.plunkettBorrowing a trick from @EclispeGC, this does exactly the same thing.
Comment #13
dawehnerThat's a great tip!!
Comment #14
alexpottCommitted a78b614 and pushed to 8.x. Thanks!