Some translatable interface string in the Views UI contain \'. This may cause confusion with translators and should be avoided.
The only documentation I found on this is from D6 t(). But IMHO still applies.

CommentFileSizeAuthor
#23 views_ui-1966514-23.patch4.45 KBsutharsan
#14 views_ui-1966514-14.patch5.46 KBsutharsan
#14 interdiff-1966514-10-14.txt3.22 KBsutharsan
#10 views_ui-1966514.patch4.03 KBivansf
#6 views_ui-1966514-6.patch3.15 KBsutharsan
#4 views_ui-1966514-4.patch144.9 KBsutharsan
#1 views_ui-1966514-1.patch5.09 KBsutharsan

Comments

sutharsan’s picture

sutharsan commented
Status: Active » Needs review
StatusFileSize
new views_ui-1966514-1.patch5.09 KB

This patch removes all the \' I could find.

jbrown’s picture

jbrown commented

#1: views_ui-1966514-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, views_ui-1966514-1.patch, failed testing.

sutharsan’s picture

sutharsan commented
Status: Needs work » Needs review
StatusFileSize
new views_ui-1966514-4.patch144.9 KB

Rerolled

jbrown’s picture

jbrown commented
Status: Needs review » Needs work

I think you uploaded the wrong patch ;-(

sutharsan’s picture

sutharsan commented
Status: Needs work » Needs review
StatusFileSize
new views_ui-1966514-6.patch3.15 KB

Lets try again ;)

attiks’s picture

attiks commented
Title: Don not use \' in translatable strings » Do not use \' in translatable strings

fix title

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

In the second hunk, should we remove the newline from the string? Also, there seems to be no need for two spaces in "or '%5D'"?

ivansf’s picture

ivansf commented
Assigned: Unassigned » ivansf

I found another one and will be fixing what #8 says.

ivansf’s picture

ivansf commented
StatusFileSize
new views_ui-1966514.patch4.03 KB

Changes from #8 and found another one.

zhangyi5’s picture

zhangyi5 commented

I am starting to review the patch.

zhangyi5’s picture

zhangyi5 commented

The syntax looks good, except that there are "<p>" and "</p>"tag in the t() function which should be discouraged and might cause trouble later.

Status: Needs review » Needs work

The last submitted patch, views_ui-1966514.patch, failed testing.

sutharsan’s picture

sutharsan commented
Assigned: ivansf » Unassigned
Status: Needs work » Needs review
StatusFileSize
new interdiff-1966514-10-14.txt3.22 KB
new views_ui-1966514-14.patch5.46 KB

Found another one in Views module. Also moved <p> outside the t() string and removed double spaces from two strings.

ivansf’s picture

ivansf commented

#10: views_ui-1966514.patch queued for re-testing.

ivansf’s picture

ivansf commented

#14 works fine.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

The patch in #14 fixes the issue to make it easier for translators, and takes into account comments by @zhangyi5 in #12. I think this is ready for RTBC as it doesn't effect functionality. Localizers may need to repeat some work if they started already.

@Sutharsan: Is there a process for making sure Drupal 8 localizers know about translatable string changes? Change notice?

sutharsan’s picture

sutharsan commented

@mradcliffe, In past releases there was a string freeze for core at the time RC1 was released. Before that time translators (usually) don't work on core strings. Therefore no need for any notification for this change.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

Oh, duh, it's been three years since the last time and I completely forgot.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

#14: views_ui-1966514-14.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, views_ui-1966514-14.patch, failed testing.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue tags: +Needs reroll

Needs a re-roll to apply against current HEAD

sutharsan’s picture

sutharsan commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new views_ui-1966514-23.patch4.45 KB

re-rolled.

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Adding RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.